Closed Bug 557234 Opened 15 years ago Closed 12 years ago

[skiplist] Add nsACString_internal::Assign to socorro skiplists

Categories

(Socorro :: Infra, task)

Product:
Socorro
Component:
Infra
Platform:
x86
All
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: wsmwk, Assigned: lars)

References

Details

Attachments

(1 file)

PR 1668 - adds "nsACString_internal::Assign.*" to the prefix skiplist.
44 bytes, text/x-github-pull-request
kairo
: review+
Details | Review
ref https://wiki.mozilla.org/Breakpad/SkipListhttps://wiki.mozilla.org/Breakpad/SkipList After consulting with bienvenu on IRC ... There are a crashes in Thunderbird and perhaps Firefox where signature ending with nsACString_internal::Assign or nsACString_internal* isn't sufficient signature [1]. Indeed nsCString::nsCString or nsCString* or other frames (eg nsCAutoString) may need to be skipped [2]. Leaving this unconfirmed until we've decided exactly what combo of changes is needed. All crashes are Thunderbird unless otherwise noted [1] nsACString_internal::Assign bp-2a717d6a-4729-41f9-bbae-4c5402100315 0 mozcrt19.dll strlen strlen.asm:81 1 xpcom_core.dll nsACString_internal::Assign xpcom/string/src/nsTSubstring.cpp:351 2 thunderbird.exe nsMsgSearchTerm::MatchRfc822String mailnews/base/search/src/nsMsgSearchTerm.cpp:1231 bp-0876c73f-c414-4ccf-8539-b62542100404 0 mozcrt19.dll strlen strlen.asm:69 1 xpcom_core.dll nsACString_internal::Assign xpcom/string/src/nsTSubstring.cpp:351 2 thunderbird.exe nsImapUrl::AddOnlineDirectoryIfNecessary mailnews/imap/src/nsImapUrl.cpp:785 [2] nsCString::nsCString, etc bp-1f9401aa-4f99-46e8-ba51-801f52100403 0 mozcrt19.dll strlen strlen.asm:69 1 xpcom_core.dll nsACString_internal::Assign xpcom/string/src/nsTSubstring.cpp:351 2 thunderbird.exe nsCString::nsCString objdir-tb/mozilla/dist/include/string/nsTString.h:80 3 thunderbird.exe nsImapProtocol::CreatePossibleTrashName mailnews/imap/src/nsImapProtocol.cpp:7348 bp-9da491db-1769-4a14-ad80-6e7c32100402 nsCString::nsCString nsCAutoString::nsCAutoString 0 mozcrt19.dll strlen strlen.asm:81 1 xpcom_core.dll nsACString_internal::Assign xpcom/string/src/nsTSubstring.cpp:351 2 thunderbird.exe nsCAutoString::nsCAutoString objdir-tb/mozilla/dist/include/string/nsTString.h:505 3 thunderbird.exe nsChromeRegistry::ProcessManifestBuffer chrome/src/nsChromeRegistry.cpp:2373 bp-436008fe-3376-4856-8cd1-d3c632100309 0 mozcrt19.dll strlen strlen.asm:69 1 xpcom_core.dll nsACString_internal::Assign xpcom/string/src/nsTSubstring.cpp:351 2 thunderbird.exe nsCAutoString::operator= objdir-tb/mozilla/dist/include/string/nsTSubstring.h:367 3 thunderbird.exe nsImapUrl::SetUri mailnews/imap/src/nsImapUrl.cpp:1218 ---- And are cases where nsACString, nsCString, etc should not be skipped? nsCString TB http://crash-stats.mozilla.com/query/query?product=Thunderbird&version=ALL%3AALL&date=&range_value=7&range_unit=days&query_search=signature&query_type=startswith&query=nsCString&build_id=&process_type=all&do_query=1 FF http://crash-stats.mozilla.com/query/query?product=Thunderbird&version=ALL%3AALL&date=&range_value=6&range_unit=days&query_search=signature&query_type=startswith&query=nsCString&build_id=&process_type=all&do_query=1 nsACSTring TB http://crash-stats.mozilla.com/query/query?product=Thunderbird&version=ALL%3AALL&date=&range_value=7&range_unit=days&query_search=signature&query_type=startswith&query=nsACString&build_id=&process_type=all&do_query=1 FF http://crash-stats.mozilla.com/query/query?product=Firefox&version=ALL%3AALL&date=&range_value=1&range_unit=days&query_search=signature&query_type=startswith&query=nsACString&build_id=&process_type=all&do_query=1
Assignee: nobody → laura
Target Milestone: --- → 2.2.4
Did you work out what changes you wanted?
Target Milestone: 2.2.4 → 2.3
Waiting on info to implement.
Target Milestone: 2.3 → ---
Component: Socorro → General
Product: Webtools → Socorro
Component: General → Infra
Blocks: 557252, 616518, 723779
1) Wayne, is something still needed to be done here? 2) If so, what exactly should be added to which skiplist (prefix or ignore list)? 3) Once you know that, can you clear up with string devs if that sounds good to be done?
Summary: Add nsACString_internal::Assign to socorro skiplists → [skiplist] Add nsACString_internal::Assign to socorro skiplists
Whiteboard: [needs info from Wayne, input from string devs]
Blocks: 739858
Blocks: 739949
No longer blocks: 739858
Blocks: 789397
Blocks: 913447
lars, can you perhaps hook me up?
Flags: needinfo?(laura)
Assignee: laura → lars
Target Milestone: --- → 65
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/85132794a70a1cab41577f7362f0ffde2fa60ff4 Merge pull request #1668 from twobraids/skiplist-nsACString_internal Fixes Bug 557234 adds nsACString_internal::... to prefix skiplist
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 830819 [details] [review] PR 1668 - adds "nsACString_internal::Assign.*" to the prefix skiplist. I guess it's OK, though we never heard from dev related to that code.
Attachment #830819 - Flags: review?(kairo) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: