557337 - Add a 'credits' appendix to the SDK documentation

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, enhancement)

Description

[Atul Varma [:atul]]

We've had a number of third-party contributions to the SDK that don't fit into a particular built-in package. It'd be nice to have a 'credits' appendix that gave mad props to anyone who's contributed.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

It would be good to get this in for 0.3 and give our contributors props!  Noelle: is this something for which you might be able to create a patch?

Comment 2

[Noelle Murata]

No problem. Just to verify;

* add a letter appendix to the index.html
* add a credits.md to the md directory
* give mad props to the folks who've contributed

is there a consolidated list of the folks who have contributed?

Comment 3

[Atul Varma [:atul]]

Unfortunately, I don't think there is ... the committer field on each of the HG changesets is actually attributed to the person who wrote the patch, so going through it is probably the best we can do for now, alas. :/

Comment 4

[Noelle Murata]

submitted:  committed changeset 529:830a2b510e2d

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Noelle: it looks like you didn't push the change you committed up to the central repository.

Before you do so, however, can you attach a patch to this bug with the change so that release drivers (currently me) can take a look at it and approve it for landing during the tree freeze?  Now that the tree is frozen in preparation for the release, only release blockers and low-risk changes should be landing, and drivers should approve low-risk changes before they land.

Comment 6

[Noelle Murata]

Attachment: proposed patch

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Looks good, thanks!  That's definitely low risk enough to land for 0.3.  Go ahead and push it, or if you're having any trouble doing so, just let me know, and I'll push it for you.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/b9302c521781.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".