557495 - PostgreSQL crashes when deleting a custom field of type BugID

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Frédéric Buclin]

DBD::Pg::db selectrow_array failed: ERREUR:  syntaxe en entrée invalide pour l'entier : «  » [for Statement "SELECT COUNT(*) FROM bugs WHERE cf_crash IS NOT NULL AND cf_crash != ''"] at Bugzilla/Field.pm line 836
	Bugzilla::Field::remove_from_db('Bugzilla::Field=HASH(0xa58a030)') called at /var/www/html/bugzilla-pg/editfields.cgi line 161
 at Bugzilla/Field.pm line 836
	Bugzilla::Field::remove_from_db('Bugzilla::Field=HASH(0xa58a030)') called at /var/www/html/bugzilla-pg/editfields.cgi line 161

This is because cf_crash is of type integer:

       Colonne       |              Type              |
---------------------+--------------------------------+
 cf_crash            | integer                        |

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

If the custom field type is FIELD_TYPE_BUG_ID, we don't need to look for '' as the DB column can only contain integers.

Comment 2

[Max Kanat-Alexander]

  BTW, I think there might be a dup of this bug filed already somewhere. Also, it will only be triggered by Pg 8.3 and later, I believe.

Comment 3

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/qa/3.6/
added t/test_custom_fields_admin.t
Committed revision 126.

Custom fields of type Date/Time also crash on deletion. I will file a separate bug for them.

Comment 4

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Field.pm
Committed revision 7115.

Committing to: bzr+ssh://[e-mail]/bugzilla/3.6/
modified Bugzilla/Field.pm
Committed revision 7073.

Committing to: bzr+ssh://[e-mail]/bugzilla/3.4/
modified Bugzilla/Field.pm
Committed revision 6757.


The Selenium script also applies to 3.4:

Committing to: bzr+ssh://[e-mail]/bugzilla/qa/3.4/
added t/test_custom_fields_admin.t
Committed revision 114.


I reported the problem with Date/Time in bug 557686.