557569 - remove macosx64 and macosx64-debug from performing talos sendchange

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect)

Description

[Mike Taylor [:bear]]

until the 32/64 bit data is reported as different items patch to remove talos master from sendchange list

Comment 1

[Mike Taylor [:bear]]

Attachment: override talos-master list for macosx64 and macosx64-debug

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 437348 [details] [diff] [review]
override talos-master list for macosx64 and macosx64-debug

This will get the 64-bit builds (debug and opt) only sending changes to the three masters specified. I don't know which ones we actually want them going to and which ones we don't, so I'm marking r?alice for that part.

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 437348 [details] [diff] [review]
override talos-master list for macosx64 and macosx64-debug

You need a change to misc.py I think to look for talos_masters in the platform dict.

Comment 4

[alice nodelman [:alice] [:anode]]

You only need to send to talos-staging-master02, talos-staging-master is pretty much defunct.

Comment 5

[Mike Taylor [:bear]]

Attachment: override talos-master list for macosx64 and macosx64-debug

Comment 6

[alice nodelman [:alice] [:anode]]

Comment on attachment 437361 [details] [diff] [review]
override talos-master list for macosx64 and macosx64-debug

List of masters looks correct to me.  This will also let us play with it in stage until we are sure that everything is working.

Comment 7

[Mike Taylor [:bear]]

Attachment: changes to misc.py to enable overriding of talos_master

Comment 8

[Chris AtLee [:catlee]]

Comment on attachment 437362 [details] [diff] [review]
changes to misc.py to enable overriding of talos_master

talos_masters isn't being copied out of GLOBAL_VARS into the platform dictionaries.  It gets copied into the per-branch dictionary though.

So, we need to either put the talos_masters setting in the per-platform defaults, or copy all the GLOBAL_VARS into the platform dict.

The first option sounds safest at this point.  You might be able to do:

'talos_masters': GLOBAL_VARS['talos_masters'],

for each of the platforms, except for the ones you want to override.

Comment 9

[Mike Taylor [:bear]]

Attachment: config.py change to add the default GLOBAL_VARS talos_masters list

added setting of talos_master item to GLOBAL_VARS default for those which are not being explicitly overridden

Comment 10

[Chris Cooper [:coop] (he/him)]

Comment on attachment 437361 [details] [diff] [review]
override talos-master list for macosx64 and macosx64-debug

http://hg.mozilla.org/build/buildbot-configs/rev/122ecf5f62ae

Comment 11

[Chris AtLee [:catlee]]

Comment on attachment 437366 [details] [diff] [review]
config.py change to add the default GLOBAL_VARS talos_masters list 

Whoops.  This, together with your previous patch will work.

Comment 12

[Chris AtLee [:catlee]]

Comment on attachment 437362 [details] [diff] [review]
changes to misc.py to enable overriding of talos_master

This should work with the new configs patch.

Comment 13

[Chris Cooper [:coop] (he/him)]

Comment on attachment 437366 [details] [diff] [review]
config.py change to add the default GLOBAL_VARS talos_masters list 

http://hg.mozilla.org/build/buildbot-configs/rev/642d27213847

Comment 14

[Mike Taylor [:bear]]

Attachment: changes to production config.py to work with misc.py changes

Comment 15

[Chris Cooper [:coop] (he/him)]

Comment on attachment 437451 [details] [diff] [review]
changes to production config.py to work with misc.py changes

http://hg.mozilla.org/build/buildbot-configs/rev/862dbf77a06e

Comment 16

[Chris Cooper [:coop] (he/him)]

Comment on attachment 437362 [details] [diff] [review]
changes to misc.py to enable overriding of talos_master

http://hg.mozilla.org/build/buildbotcustom/rev/9726abec8642

Comment 17

[Mike Taylor [:bear]]

Attachment: enable macosx64 to send to talos-staging master's

Comment 18

[alice nodelman [:alice] [:anode]]

We actually no longer need this - we have snow leopard up and ready to test macosx64 bit builds.

Comment 19

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #18)
> We actually no longer need this - we have snow leopard up and ready to test
> macosx64 bit builds.

So, this should be WONTFIX'd?

Comment 20

[Mike Taylor [:bear]]

The reason for this bug was cleared up before the patches landed.  Confirmed that the are not present in the source tree - marking as WONTFIX