Hook up IMAP to msgAsyncPrompt service and make its password prompts serial again

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: standard8, Assigned: Bienvenu)

Tracking

Firefox Tracking Flags

(blocking-thunderbird3.1 beta2+, thunderbird3.1 beta2-fixed)

Details

Attachments

(1 attachment, 5 obsolete attachments)

(Reporter)

Description

9 years ago
Spinning out the separate work from bug 338549. We need to hook up IMAP to the msgAsyncPrompt service so that the prompts will occur in serial fashion.

Attachment 435000 [details] [diff] has a first version for this bug.
(Assignee)

Comment 1

9 years ago
this patch breaks the retry logic when a bad password is entered - we keep sending the bad password. I suspect when BenB did his auth work, he might have broken this patch...or made the merge hard.
(Assignee)

Comment 2

9 years ago
Created attachment 437680 [details] [diff] [review]
fix new password entry

this gets the patch working as well as it did before. There's still an issue where if you retry a password, and there was a second password request waiting its turn, you press retry on the first password, but get the second password dialog. To fix this, I think we'd need to make the async password prompter know about retry, so that it doesn't put up the queued request. 

I would think pop3 would have this same issue. I need to refresh my memory about how the async password service works...
(Assignee)

Comment 3

9 years ago
How can we write meaningful imap tests for this, given that we can only have a single fake imap server? The async prompter code can have its own tests, but testing it with the imap code would seem to require multiple imap servers.
(Assignee)

Comment 4

9 years ago
I think nsIMsgAsyncPromptListener's onPromptStart needs to return a tri-state value, ok, cancel, enter new password. This would put the prompter code in a mode where it's waiting for a prompt request from the same key, instead of just handling the next prompt request in the queue. Standard8, I'm happy to have a quick try at doing that. I'll put up a patch in a little bit.
(Reporter)

Comment 5

9 years ago
(In reply to comment #3)
> How can we write meaningful imap tests for this, given that we can only have a
> single fake imap server? The async prompter code can have its own tests, but
> testing it with the imap code would seem to require multiple imap servers.

The best way I can think would be to have multiple fake servers running in separate processes. This kinda implies mozmill which we haven't got hooked up yet.
(Reporter)

Comment 6

9 years ago
(In reply to comment #4)
> I think nsIMsgAsyncPromptListener's onPromptStart needs to return a tri-state
> value, ok, cancel, enter new password. This would put the prompter code in a
> mode where it's waiting for a prompt request from the same key, instead of just
> handling the next prompt request in the queue. Standard8, I'm happy to have a
> quick try at doing that. I'll put up a patch in a little bit.

I'm a bit concerned about that sort of solution, as it isn't really going to be compatible with core code if/when we can move across to that. Although we may be able to get a change in there.

The other question would be what happens if it doesn't get a prompt request for the same key... is it going to just keep stacking them up?
(Assignee)

Comment 7

9 years ago
(In reply to comment #6)

> I'm a bit concerned about that sort of solution, as it isn't really going to be
> compatible with core code if/when we can move across to that. Although we may
> be able to get a change in there.

If we went to some sort of non-modal password approach, we could in theory have multiple password prompts up at the same time, e.g., stacked sliding alerts. But I don't think the situation the way it is now is acceptable, and I don't see a way of fixing it without changing the interface.

> 
> The other question would be what happens if it doesn't get a prompt request for
> the same key... is it going to just keep stacking them up?

If the listener promises to reprompt, but doesn't, it would effectively block new password prompts. I was planning on adding a comment to the idl to that effect. Maybe the nsIMsgAsyncPromptListener could do the re-prompting itself, by just re-running the current prompt, which would avoid that issue.
(Reporter)

Comment 8

9 years ago
Ok, let's go with that for now, and we can sort out core later ;-)
(Assignee)

Comment 9

9 years ago
Actually, my suggestion won't work - we don't know that the user wants to retry until the password has actually failed, and we've prompted the user, so it can't be a return value from onPrompt, unless we delay the onPrompt callback until after that whole process is done. That would mean the user couldn't get multiple logons going on at the same time, which I think would be bad.

A couple other possibilities - we could have a parameter to queueAsyncAuthPrompt that forces the new retry prompt to run immediately, so that it would pop up on top of any existing password prompt, which isn't perfect, but is less confusing to the user. Or the retry code could simply not use the queueAsyncAuthPrompt at all, but that would allow other password prompts to come up...so I think I'll try adding a param to queueAsyncAuthPrompt.
(Assignee)

Comment 10

9 years ago
Created attachment 437961 [details] [diff] [review]
proposed fix

this implements my idea for allowing the client code to implement reprompting by jumping the password prompt queue for that case.
Attachment #437680 - Attachment is obsolete: true
Attachment #437961 - Flags: superreview?(bugzilla)
Attachment #437961 - Flags: review?(bugzilla)
(Assignee)

Updated

9 years ago
Whiteboard: [first version available, needs update + tests] → [has patch for review Standard8]
(Reporter)

Comment 11

9 years ago
I've not looked at the patch yet, but I'm getting errors like:

../../../mozilla/dist/include/nsMsgIncomingServer.h: In member function ‘virtual nsresult nsImapIncomingServer::AsyncGetPassword(nsIImapProtocol*, PRBool, nsACString_internal&)’:
../../../mozilla/dist/include/nsMsgIncomingServer.h:111: error: ‘nsCString nsMsgIncomingServer::m_password’ is private
/Users/moztest/comm/main/src/mailnews/imap/src/nsImapIncomingServer.cpp:2113: error: within this context
../../../mozilla/dist/include/nsMsgIncomingServer.h:111: error: ‘nsCString nsMsgIncomingServer::m_password’ is private
/Users/moztest/comm/main/src/mailnews/imap/src/nsImapIncomingServer.cpp:2129: error: within this context
../../../mozilla/dist/include/nsMsgIncomingServer.h:111: error: ‘nsCString nsMsgIncomingServer::m_password’ is private

when trying to build it.
(Assignee)

Comment 12

9 years ago
Created attachment 438978 [details] [diff] [review]
include nsMsgIncomingServer.hd in diffs

sorry about that; this should build...
Attachment #437961 - Attachment is obsolete: true
Attachment #438978 - Flags: superreview?(bugzilla)
Attachment #438978 - Flags: review?(bugzilla)
Attachment #437961 - Flags: superreview?(bugzilla)
Attachment #437961 - Flags: review?(bugzilla)
(Reporter)

Comment 13

9 years ago
Did you look at xpcshell tests? I'm seeding a failure:

TEST-UNEXPECTED-FAIL | /Users/moztest/comm/main/tb/mozilla/_tests/xpcshell/test_imap/unit/test_imapPasswordFailure.js | test failed (with xpcshell return code: 
...
TEST-UNEXPECTED-FAIL | /Users/moztest/comm/main/tb/mozilla/_tests/xpcshell/test_imap/unit/test_imapPasswordFailure.js | false == true - See following stack:
JS frame :: /Users/moztest/comm/main/src/mozilla/testing/xpcshell/head.js :: do_throw :: line 257
JS frame :: /Users/moztest/comm/main/src/mozilla/testing/xpcshell/head.js :: do_check_eq :: line 287
JS frame :: /Users/moztest/comm/main/src/mozilla/testing/xpcshell/head.js :: do_check_true :: line 299
JS frame :: /Users/moztest/comm/main/tb/mozilla/_tests/xpcshell/test_imap/unit/test_imapPasswordFailure.js :: run_test :: line 153
JS frame :: /Users/moztest/comm/main/src/mozilla/testing/xpcshell/head.js :: _execute_test :: line 151
JS frame :: -e :: <TOP_LEVEL> :: line 1
(Reporter)

Comment 14

9 years ago
I can't run the patch and get prompts, I'm getting: 

Error: runnablePrompter:run: TypeError: prompter.first.onPromptStart is not a function

Source File: file:///Users/moztest/comm/main/tb/mozilla/dist/ShredderDebug.app/Contents/MacOS/components/msgAsyncPrompter.js
Line: 61

Did you miss including the msgAsyncPrompter.js changes?
(Reporter)

Updated

9 years ago
Attachment #438978 - Flags: superreview?(bugzilla)
Attachment #438978 - Flags: review?(bugzilla)
(Reporter)

Comment 15

9 years ago
Comment on attachment 438978 [details] [diff] [review]
include nsMsgIncomingServer.hd in diffs

>@@ -110,13 +110,14 @@ interface nsIImapIncomingServer : nsISup

>+  ACString PromptPassword(in nsIMsgWindow aWindow);

nit: needs documentation
 
>+NS_IMETHODIMP
>+nsImapIncomingServer::AsyncGetPassword(nsIImapProtocol *aProtocol,
>+                                       PRBool aNewPasswordRequested,
>+                                       nsACString &aPassword)
>+{
>+  nsresult rv;
>+  if (m_password.IsEmpty())
>+  {

nit: rv can be declared inside the if statement.

>+NS_IMETHODIMP
>+nsImapProtocol::OnPromptAuthAvailable()
>+{
>+  NS_NOTREACHED("Did not expect to get imap protocol queuing up auth "
>+                "connections");
>+  return NS_OK;
>+}

Would it, in theory be possible that a user had two windows and tried access two folders on the same imap server that we could hit this?

My only other concern is that the addition of:

+   * @param aPromptImmediately If the user is retrying a failed password, we
+   *                           need to prompt immediately, even if there is a
+   *                           prompt up.

won't actually work on Mac. I'm not 100% sure, but I think the way modal dialogs there will stop that happening, and therefore Mac would still have the issue of confusion over failed passwords. Generally, I think we'll probably get away with it, but may be worth having a bug open on it so that we know it is an issue.

Cancelling reviews as I think the patch needs update for the missing changes - they probably also will fix the unit test as well.
(Reporter)

Updated

9 years ago
Whiteboard: [has patch for review Standard8] → [needs updated patch]
(Assignee)

Comment 16

9 years ago
Created attachment 439237 [details] [diff] [review]
include js file in diffs.

this also addresses the nit. Yes, the unit tests have been passing fine for me on windows but have not tried the mac. I can do that in a bit...
Attachment #438978 - Attachment is obsolete: true
Attachment #439237 - Flags: superreview?(bugzilla)
Attachment #439237 - Flags: review?(bugzilla)
(Assignee)

Updated

9 years ago
Whiteboard: [needs updated patch] → [needs review of new patch]
(Reporter)

Comment 17

9 years ago
Comment on attachment 439237 [details] [diff] [review]
include js file in diffs.

In general this is looking good. I'm not totally sure I like the effect of sticking up the prompt immediately if we fail, but I'm not sure that's just a side effect of these changes as we'd get the retry/enter/cancel dialog coming up in front anyway.

I think we can't do much about that until we drop modal dialogs for these things and this is much better than what we have now.

A few comments:

>+   * @param aPromptImmediately If the user is retrying a failed password, we
>+   *                           need to prompt immediately, even if there is a
>+   *                           prompt up.

I think we should note that this doesn't necessarily happen on Mac, but will happen in front of any other queued prompts.

>+function do_timeout_function(aDelayInMS, aFunc, aFuncThis, aFuncArgs) {

I think this function got pasted in either the wrong place, or just incorrectly got pasted...

>+  ACString PromptPassword(in nsIMsgWindow aWindow);

nit: please add a little bit of documentation for this. Might be worth adding that it may stick up modal prompts.

>+NS_IMETHODIMP
>+nsImapProtocol::OnPromptAuthAvailable()
>+{
>+  NS_NOTREACHED("Did not expect to get imap protocol queuing up auth "
>+                "connections");
>+  return NS_OK;
>+}
>+
>+NS_IMETHODIMP
>+nsImapProtocol::OnPromptCanceled()
>+{
>+  // A prompt was cancelled, so notify the imap thread.
>   return NS_OK;
> }

We can reach both of these so we need to implement them. Test case: In separate tabs, open up different folders of the same server. Restart Thunderbird and enter the password once. The assertions are then shown, and the other folders don't finish loading.
Attachment #439237 - Flags: superreview?(bugzilla)
Attachment #439237 - Flags: review?(bugzilla)
Attachment #439237 - Flags: review-
(Reporter)

Updated

9 years ago
Whiteboard: [needs review of new patch] → [needs a couple of small tweaks to patch]
(Assignee)

Comment 18

9 years ago
Created attachment 439943 [details] [diff] [review]
patch addressing comments

This addresses the review comments. I think you can still get into some odd situations, especially with canceling, but overall it's better than what we have now.
Attachment #439237 - Attachment is obsolete: true
Attachment #439943 - Flags: superreview?(bugzilla)
Attachment #439943 - Flags: review?(bugzilla)
(Assignee)

Updated

9 years ago
Whiteboard: [needs a couple of small tweaks to patch] → [needs review standard8]
(Assignee)

Comment 19

9 years ago
Created attachment 440082 [details] [diff] [review]
fix cancel handling

This should fix canceling, by propagating the rv from GetPassword over to the imap thread.
Attachment #439943 - Attachment is obsolete: true
Attachment #440082 - Flags: superreview?(bugzilla)
Attachment #440082 - Flags: review?(bugzilla)
Attachment #439943 - Flags: superreview?(bugzilla)
Attachment #439943 - Flags: review?(bugzilla)
(Reporter)

Comment 20

9 years ago
Comment on attachment 440082 [details] [diff] [review]
fix cancel handling

Yep, that's much better. Like you said before, there's some strange effects with password cancelling, but I think we can work on those later and take what we've got as the big improvement for 3.1.
Attachment #440082 - Flags: superreview?(bugzilla)
Attachment #440082 - Flags: superreview+
Attachment #440082 - Flags: review?(bugzilla)
Attachment #440082 - Flags: review+
(Assignee)

Comment 21

9 years ago
fixed for 3.1 b2.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
status-thunderbird3.1: --- → beta2-fixed
Resolution: --- → FIXED
Whiteboard: [needs review standard8]
You need to log in before you can comment on or make changes to this bug.