557623 - Tab sync broken on fennec since session-store was added

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Ed Lee :Mardak]

Bug 551889 added something to "@mozilla.org/browser/sessionstore;1" but it doesn't implement nsISessionStore, so Weave fails to detect missing sessionstore and provide a fake service now that bug 548939 has us using nsISessionStore.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Ed Lee :Mardak]

Comment on attachment 437386 [details] [diff] [review]
v1

abort!

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #0)
> Bug 551889 added something to "@mozilla.org/browser/sessionstore;1" but it
> doesn't implement nsISessionStore

Indeed we did. The component will be used to create an nsISessionStore in the future. Currently it is tracking tabs so we can support getting the last open tabs when starting up.

I can't say that the Fennec nsISessionStore will match the Firefox nsISessionStore either. We'll support methods that make sense for the mobile app.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

I could change our contract to "@mozilla.org/mobile/sessionstore;1"

Comment 5

[Ed Lee :Mardak]

Attachment: v2

Comment 6

[Ed Lee :Mardak]

(In reply to comment #4)
> I could change our contract to "@mozilla.org/mobile/sessionstore;1"
Sounds like mconnor would be happy with that. We'll land the fix in Weave as well.

Comment 7

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Comment on attachment 437396 [details] [diff] [review]
v2

r=zpao

Comment 8

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/6f00901b8e6e
Check for existance of both cid and iface in Cc/Ci to decide to use the platform's service or fake one. Remove unused lazyInstance to clean up API (iface == string not object).

Comment 9

[Tracy Walker [:tracy]]

verified with Fennec1.1a2 on desktop with Weave 1.2b4