Tab sync broken on fennec since session-store was added

VERIFIED FIXED in 1.2

Status

Cloud Services
Firefox Sync: Backend
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

unspecified
Points:
---
Dependency tree / graph
Bug Flags:
blocking-weave1.2 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

v2
2.83 KB, patch
zpao
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
Bug 551889 added something to "@mozilla.org/browser/sessionstore;1" but it doesn't implement nsISessionStore, so Weave fails to detect missing sessionstore and provide a fake service now that bug 548939 has us using nsISessionStore.
Flags: blocking-weave1.2+
(Assignee)

Updated

8 years ago
Target Milestone: --- → 1.2
(Assignee)

Comment 1

8 years ago
Created attachment 437386 [details] [diff] [review]
v1
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #437386 - Flags: review?(paul)
(Assignee)

Comment 2

8 years ago
Comment on attachment 437386 [details] [diff] [review]
v1

abort!
Attachment #437386 - Flags: review?(paul) → review-
(In reply to comment #0)
> Bug 551889 added something to "@mozilla.org/browser/sessionstore;1" but it
> doesn't implement nsISessionStore

Indeed we did. The component will be used to create an nsISessionStore in the future. Currently it is tracking tabs so we can support getting the last open tabs when starting up.

I can't say that the Fennec nsISessionStore will match the Firefox nsISessionStore either. We'll support methods that make sense for the mobile app.
I could change our contract to "@mozilla.org/mobile/sessionstore;1"
(Assignee)

Comment 5

8 years ago
Created attachment 437396 [details] [diff] [review]
v2
Attachment #437386 - Attachment is obsolete: true
Attachment #437396 - Flags: review?(paul)
(Assignee)

Comment 6

8 years ago
(In reply to comment #4)
> I could change our contract to "@mozilla.org/mobile/sessionstore;1"
Sounds like mconnor would be happy with that. We'll land the fix in Weave as well.
Comment on attachment 437396 [details] [diff] [review]
v2

r=zpao
Attachment #437396 - Flags: review?(paul) → review+
(Assignee)

Comment 8

8 years ago
http://hg.mozilla.org/labs/weave/rev/6f00901b8e6e
Check for existance of both cid and iface in Cc/Ci to decide to use the platform's service or fake one. Remove unused lazyInstance to clean up API (iface == string not object).
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Depends on: 557649
verified with Fennec1.1a2 on desktop with Weave 1.2b4
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.