Closed Bug 557623 Opened 12 years ago Closed 12 years ago

Tab sync broken on fennec since session-store was added

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 551889 added something to "@mozilla.org/browser/sessionstore;1" but it doesn't implement nsISessionStore, so Weave fails to detect missing sessionstore and provide a fake service now that bug 548939 has us using nsISessionStore.
Flags: blocking-weave1.2+
Target Milestone: --- → 1.2
Attached patch v1 (obsolete) — Splinter Review
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #437386 - Flags: review?(paul)
Comment on attachment 437386 [details] [diff] [review]
v1

abort!
Attachment #437386 - Flags: review?(paul) → review-
(In reply to comment #0)
> Bug 551889 added something to "@mozilla.org/browser/sessionstore;1" but it
> doesn't implement nsISessionStore

Indeed we did. The component will be used to create an nsISessionStore in the future. Currently it is tracking tabs so we can support getting the last open tabs when starting up.

I can't say that the Fennec nsISessionStore will match the Firefox nsISessionStore either. We'll support methods that make sense for the mobile app.
I could change our contract to "@mozilla.org/mobile/sessionstore;1"
Attached patch v2Splinter Review
Attachment #437386 - Attachment is obsolete: true
Attachment #437396 - Flags: review?(paul)
(In reply to comment #4)
> I could change our contract to "@mozilla.org/mobile/sessionstore;1"
Sounds like mconnor would be happy with that. We'll land the fix in Weave as well.
http://hg.mozilla.org/labs/weave/rev/6f00901b8e6e
Check for existance of both cid and iface in Cc/Ci to decide to use the platform's service or fake one. Remove unused lazyInstance to clean up API (iface == string not object).
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
verified with Fennec1.1a2 on desktop with Weave 1.2b4
Status: RESOLVED → VERIFIED
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.