557671 - OpenGL Image Layers need thread safety

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Bas Schouten (:bas.schouten)]

Attachment: Add locks to OGL image layers

YCbCr images should be threadsafe, SetData may be called on one thread while they are being drawn on another thread. Additionally SetCurrentImage and GetCurrentImage should lock while adding/releasing their references.

We upload cairo surface image bits from setdata which should always be called on the main thread, so we don't need locking in there for now.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to comment #0)
> Created an attachment (id=437443) [details]
> Add locks to OGL image layers
> 
> YCbCr images should be threadsafe, SetData may be called on one thread while
> they are being drawn on another thread.

This is actually not allowed. SetData must complete before you can call SetCurrentImage with that image.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

So, remove the locking on the YCbCr images.

Also, use mozilla::Monitor instead of PR_ stuff.

Comment 3

[Bas Schouten (:bas.schouten)]

Attachment: Add locks to OGL image layers v2

Processed roc's comments.

Comment 4

[Bas Schouten (:bas.schouten)]

Attachment: Add locks to OGL image layers v3

Remove two useless includes.

Comment 5

[Bas Schouten (:bas.schouten)]

http://hg.mozilla.org/mozilla-central/rev/afca4a8ad127