[mozmill] Cannot validate tab id in testOpenInForegroundTab (testOpenInForeground.js)

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill-test-failure])

Attachments

(3 obsolete attachments)

(Assignee)

Description

9 years ago
Looks like opening the last tab with a middle click doesn't work.

could not validate element ID: id with text 3
(Assignee)

Comment 1

8 years ago
Kenny, would you like to check what's wrong with this test? But only if you are able to reproduce it.
I'm on it.
(Assignee)

Comment 3

8 years ago
Thanks Kenny!
Assignee: nobody → kennywong.kh
Status: NEW → ASSIGNED
Created attachment 458398 [details] [diff] [review]
Patch v1 - waitForPageLoad

Hi Kenny,

If you don't mind I will look at this bug. 

This bug is a result of failing an assert on the last opened tab looking at the textContent of the linkId. The textContent value has an empty string. As it's the last tab we open in the foreground before the check, we are missing a waitForPageLoad as waitForElement is not enough time to wait for the textContent property to have a value. The following patch was written against 1.9.2 and works against this branch along with 1.9.1.
Assignee: kennywong.kh → aaron.train
Attachment #458398 - Flags: review?(anthony.s.hughes)

Updated

8 years ago
OS: Windows XP → All
Version: unspecified → 3.5 Branch
Created attachment 458677 [details] [diff] [review]
Patch v1 - waitForPageLoad (1.9.2)

As per Henrik's request to place the check inside the for loop.
Attachment #458398 - Attachment is obsolete: true
Attachment #458677 - Flags: review?
Attachment #458398 - Flags: review?(anthony.s.hughes)

Updated

8 years ago
Attachment #458677 - Flags: review? → review?(anthony.s.hughes)
Created attachment 458680 [details] [diff] [review]
Patch v1 - waitForPageLoad (1.9.1)

Same patch for 1.9.1
Attachment #458680 - Flags: review?(anthony.s.hughes)
(Assignee)

Comment 7

8 years ago
I don't think that we need those patches anymore. Given my research on bug 552594 the patch there should also fix this test failure.
Depends on: 552594
(Assignee)

Comment 8

8 years ago
Should be fixed now with bug 552594. Please keep watching the results the next days and reopen if necessary.
Assignee: aaron.train → hskupin
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Attachment #458677 - Attachment is obsolete: true
Attachment #458677 - Flags: review?(anthony.s.hughes)
(Assignee)

Updated

8 years ago
Attachment #458680 - Attachment is obsolete: true
Attachment #458680 - Flags: review?(anthony.s.hughes)
(Assignee)

Comment 9

8 years ago
Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Tabbed Browser → Mozmill Tests
Product: Firefox → Mozilla QA
QA Contact: tabbed.browser → mozmill-tests
Version: 3.5 Branch → unspecified
You need to log in before you can comment on or make changes to this bug.