Closed Bug 557880 Opened 15 years ago Closed 15 years ago

CodegenLIR: use new opcode names

Categories

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect, P4)

Product:
Tamarin Graveyard
Component:
Baseline JIT (CodegenLIR)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Future

People

(Reporter: edwsmith, Assigned: edwsmith)

References

Details

Attachments

(3 obsolete files)

Update the JIT to use the new standard opcode names instead of legacy alias names. See the writeup in Bug 504506 - nanojit: The Great Opcode Renaming for details and rationale.
Attachment #437638 - Attachment is patch: true
Attachment #437638 - Attachment mime type: application/octet-stream → text/plain
Attachment #437638 - Flags: review?(wmaddox)
Depends on: 504506
Priority: -- → P4
Target Milestone: --- → Future
Attachment #437638 - Flags: review?(wmaddox) → review?(rreitmai)
Seems like we need an updated proposal prior to landing these patches, no? There still seems to be some room for interpretation of the rules outlined in the comments. For example, the load operators mostly look like conversions in this patch, i.e. 'x2y', whereas the store versions do not. loading a byte is ldb2l where store is stb? shouldn't it be stl2b ?
(In reply to comment #1) > Seems like we need an updated proposal prior to landing these patches, no? This patch, perhaps. The opcode renaming of LIRopcode.tbl has already occurred. See comments continued on bug 504506.
Comment on attachment 437638 [details] [diff] [review] Rename references to LOpcode enums Fair enough.
Attachment #437638 - Flags: review?(rreitmai) → review+
Assignee: nobody → edwsmith
Attachment #437638 - Attachment is obsolete: true
Comment on attachment 437638 [details] [diff] [review] Rename references to LOpcode enums TR: http://hg.mozilla.org/tamarin-redux/rev/86450b73d59f
Renames were done mechanically with Eclipse CDT.
Attachment #439528 - Flags: review?(rreitmai)
Attachment #439528 - Flags: review?(rreitmai) → review+
Comment on attachment 439528 [details] [diff] [review] Rename LirHelper functions according to new opcode names also: i2p() -> l2p() p2i() -> p2l() u2p() -> ul2up()
TR: http://hg.mozilla.org/tamarin-redux/rev/a86df3624040
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
last time for these, again using eclipse's rename refactoring.
Attachment #439528 - Attachment is obsolete: true
Attachment #441878 - Flags: review?(rreitmai)
Attachment #441878 - Flags: review?(rreitmai) → review+
Comment on attachment 441878 [details] [diff] [review] (v2) Rename LirHelper functions according to new opcode names TR: http://hg.mozilla.org/tamarin-redux/rev/256d9d6b3edf
Attachment #441878 - Attachment is obsolete: true
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: