CodegenLIR: use new opcode names

RESOLVED FIXED in Future

Status

P4
normal
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: edwsmith, Assigned: edwsmith)

Tracking

unspecified
Future

Details

Attachments

(3 obsolete attachments)

(Assignee)

Description

9 years ago
Created attachment 437638 [details] [diff] [review]
Rename references to LOpcode enums

Update the JIT to use the new standard opcode names instead of legacy alias names.  

See the writeup in Bug 504506 - nanojit: The Great Opcode Renaming for details and rationale.
(Assignee)

Updated

9 years ago
Attachment #437638 - Attachment is patch: true
Attachment #437638 - Attachment mime type: application/octet-stream → text/plain
Attachment #437638 - Flags: review?(wmaddox)
(Assignee)

Updated

9 years ago
Depends on: 504506
Priority: -- → P4
Target Milestone: --- → Future
(Assignee)

Updated

9 years ago
Attachment #437638 - Flags: review?(wmaddox) → review?(rreitmai)

Comment 1

9 years ago
Seems like we need an updated proposal prior to landing these patches, no? 

There still seems to be some room for interpretation of the rules outlined in the comments.  

For example, the load operators mostly look like conversions in this patch, i.e. 'x2y', whereas the store versions do not.

loading a byte is ldb2l where store is stb?  shouldn't it be stl2b ?
(Assignee)

Comment 2

9 years ago
(In reply to comment #1)
> Seems like we need an updated proposal prior to landing these patches, no? 

This patch, perhaps.  The opcode renaming of LIRopcode.tbl has already occurred.  See comments continued on bug 504506.

Comment 3

9 years ago
Comment on attachment 437638 [details] [diff] [review]
Rename references to LOpcode enums

Fair enough.
Attachment #437638 - Flags: review?(rreitmai) → review+
(Assignee)

Updated

9 years ago
Assignee: nobody → edwsmith
(Assignee)

Updated

9 years ago
Attachment #437638 - Attachment is obsolete: true
(Assignee)

Comment 4

9 years ago
Comment on attachment 437638 [details] [diff] [review]
Rename references to LOpcode enums

TR: http://hg.mozilla.org/tamarin-redux/rev/86450b73d59f
(Assignee)

Comment 5

9 years ago
Created attachment 439528 [details] [diff] [review]
Rename LirHelper functions according to new opcode names

Renames were done mechanically with Eclipse CDT.
Attachment #439528 - Flags: review?(rreitmai)

Updated

9 years ago
Attachment #439528 - Flags: review?(rreitmai) → review+
(Assignee)

Comment 6

9 years ago
Comment on attachment 439528 [details] [diff] [review]
Rename LirHelper functions according to new opcode names

also:
i2p() -> l2p()
p2i() -> p2l()
u2p() -> ul2up()
(Assignee)

Comment 7

9 years ago
TR: http://hg.mozilla.org/tamarin-redux/rev/a86df3624040
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 9

9 years ago
Created attachment 441878 [details] [diff] [review]
(v2) Rename LirHelper functions according to new opcode names

last time for these, again using eclipse's rename refactoring.
Attachment #439528 - Attachment is obsolete: true
Attachment #441878 - Flags: review?(rreitmai)

Updated

9 years ago
Attachment #441878 - Flags: review?(rreitmai) → review+
(Assignee)

Comment 10

9 years ago
Comment on attachment 441878 [details] [diff] [review]
(v2) Rename LirHelper functions according to new opcode names

TR: http://hg.mozilla.org/tamarin-redux/rev/256d9d6b3edf
Attachment #441878 - Attachment is obsolete: true
(Assignee)

Updated

9 years ago
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.