557887 - Rename LOpcode enums in LIR.h

Status: RESOLVED FIXED

(Core Graveyard :: Nanojit, defect)

Description

[Edwin Smith]

Attachment: Mechanical rename of the LIR_xxx enum references to use standard names.

To be done mechanically using an updated script from bug 504506.

Comment 1

[Edwin Smith]

Attachment: Rename LIR opcodes in LIR.h

mechanical renamed using rename_LIR.pl, then backed out the alias patch hunks, and updated the pointer-sized aliases to use the new opcodes instead of PTR_SIZE macros using old opcodes.

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 439542 [details] [diff] [review]
Rename LIR opcodes in LIR.h

>-        LIR_param   = PTR_SIZE(LIR_iparam, LIR_qparam),
>+        LIR_param   = LIR_paramp,

There wasn't much point doing these as they'll disappear eventually, but it doesn't hurt.


>-    // Used for LIR_iparam, LIR_qparam.
>+    // Used for LIR_paraml, LIR_paramq.
>     class LInsP
>     {
>     private:
>@@ -1292,7 +1292,7 @@
>         LIns* getLIns() { return &ins; };
>     };
> 
>-    // Used for LIR_int and LIR_alloc.
>+    // Used for LIR_imml and LIR_allocp.

Might as well say "Used for LIR_paramp" for LInsP, to match "Used for ... LIR_allocp".


The rest looks fine and passed testing on TM.

Comment 3

[Edwin Smith]

(In reply to comment #2)
> (From update of attachment 439542 [details] [diff] [review])
> >-        LIR_param   = PTR_SIZE(LIR_iparam, LIR_qparam),
> >+        LIR_param   = LIR_paramp,
> 
> There wasn't much point doing these as they'll disappear eventually, but it
> doesn't hurt.

yeah, my thoughts initially, but i found myself running "Find references" a lot in eclipse CDT, to find legacy alias references, and this patch reduces the false positivies.

> Might as well say "Used for LIR_paramp" for LInsP, to match "Used for ...
> LIR_allocp".

Follies of automatic renaming.  Will fix before pushing.

Comment 4

[Edwin Smith]

NC: http://hg.mozilla.org/projects/nanojit-central/rev/944433df3759

Comment 5

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/tracemonkey/rev/79346fc24d62

Comment 6

[Edwin Smith]

TR: http://hg.mozilla.org/tamarin-redux/rev/e1e3fb1e0c27

Comment 7

[Edwin Smith]

Attachment: LIR.h/cpp, Assembler.h/cpp: rename intel LIR opcode names to C names

done using updated rename_LIR.pl from bug 504506.

Comment 8

[Edwin Smith]

Comment on attachment 440665 [details] [diff] [review]
LIR.h/cpp, Assembler.h/cpp: rename intel LIR opcode names to C names

NJ: http://hg.mozilla.org/projects/nanojit-central/rev/2787af46329c

Comment 9

[Edwin Smith]

TR: http://hg.mozilla.org/tamarin-redux/rev/043d358f31cc

Comment 10

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/79346fc24d62