557992 - build failure(s) following the OOPP checkin (requires --enable-libxul)

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

Attachment: summary of build errors

The OOPP checkin on Gecko 1.9.2 sets MOZ_ENABLE_LIBXUL=1
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/84ba4d805430

(http://hg.mozilla.org/releases/mozilla-1.9.2/diff/84ba4d805430/configure.in)

Setting 'MOZ_ENABLE_LIBXUL=' in camino/confvars.sh allows the build to succeed (and 'MOZ_IPC=', but I think it is optional, atm, as it is -still- disabled by default on OS X)

Comment 1

[philippe (part-time)]

Attachment: full buildlog

Comment 2

[philippe (part-time)]

Attachment: possible patch

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #0)
> Setting 'MOZ_ENABLE_LIBXUL=' in camino/confvars.sh allows the build to succeed
> (and 'MOZ_IPC=', but I think it is optional, atm, as it is -still- disabled by
> default on OS X)

I'd prefer we do what philippe's patch does and keep MOZ_IPC= in confvars.sh just so we don't get blindsided (broken again, if we manage to be building by then :P) when they do turn it on for some flavor of Mac OS X builds (since it will never work for us, anyway).

Comment 4

[Eiichi]

For reference:

1) First, my test failed as  philippe.
2) Adding --disable-libxul in my .mozconfig, I succeeded to build.

Configuring Build Options - MDC (https://developer.mozilla.org/en/Configuring_Build_Options) says that as below;
---
--enable-static requires --disable-libxul. If you use --enable-static, it is recommended that you also --disable-tests.

Comment 5

[Eiichi]

1) No patch --enable-static --disable-libxul --disable-tests --> Build succeeds.
2) With patch --enable-libxul --> Build fails.

philippe, did you test with --enable-libxul option?

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

MOZ_ENABLE_LIBXUL=1 is now the default in configure(.in), so if you don't specify anything, static builds break.  Static builds need to work out of the box, so this needs to be in confvars.sh.

Comment 7

[Stuart Morgan]

Comment on attachment 437764 [details] [diff] [review]
possible patch

sr=smorgan

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

First push!
http://hg.mozilla.org/camino/rev/10dbf60b3b21

Comment 9

[Eiichi]

MOZ_ENABLE_LIBXUL=1 is the default in configure(.in), but without --enable-libxul mozilla-config.h doesn't include MOZ_ENABLE_LIBXUL=1.

Without --enable-libxul build succeeds.
But with --enable-libxul build still fails.
---
/obj-i386-apple-darwin8.11.1/camino/build/Deployment/Camino.app/Contents/MacOS/components
pbxcp: libcookie.dylib: No such file or directory
** BUILD FAILED **
make[4]: *** [libs] Error 1
make[3]: *** [libs_tier_app] Error 2
make[2]: *** [tier_app] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2

Shouldn't I add --enable-libxul in .mozconfig?

Comment 10

[philippe (part-time)]

(In reply to comment #9)
Camino can't build libxul, only Firefox can.

Comment 11

[Eiichi]

(In reply to comment #10)
> (In reply to comment #9)
> Camino can't build libxul, only Firefox can.

Thanks, philippe.