55801 - Null XUL DOM Methods unimplemented

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[hand]

From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 5.0)
BuildID:    2000091312

Many methods for XUL DOM are unimplemented.

The ones I have encountered are:

Document::setAttributeNS and Attribute::childNode

I assume that this is because these methods don't do anything or return empty 
Nodelists/NamedNodeMaps.

I do not believe that their absense will block developments on Mozilla, but 
they certainly do slow development and are somewhat annoying.

I think "grep NS_NOTYETIMPLEMENTED nsXUL*.cpp" finds most of them.

I'm only filing this for the record - it would be nice if they were 
implemented.  I just hope that at a minimum, there is a switch that causes 
those methods to return NS_ERROR_NOT_IMPLEMENTED rather than asserting for 
Mozilla 1.0

Comment 1

[Keyser Sose]

Reporter is this still  a problem in the latest nightlies?

Comment 2

[Asa Dotzler [:asa]]

setting bug status to New

Comment 3

[Prashant Desale]

QA contact Update

Comment 4

[Gervase Markham [:gerv]]

Yep, there's still loads of them there. About 25, in fact, split about evenly 
across nsXULElement.cpp, nsXULAttribute.cpp and nsXULDocument.cpp.

Gerv

Comment 5

[Prashant Desale]

Updating QA contact to Shivakiran Tummala.

Comment 6

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 7

[Boris Zbarsky [:bzbarsky]]

> Document::setAttributeNS

There is no such beast.

> Attribute::childNode

This is unimplemented in non-XUL too.

In fact, now that jst has made nsXULDocument inherit from nsDocument and sicking
has landed his child/attr rewrite most of these issues are gone (nsXULAttributes
is no more, for example).

The remaining issues will be solved by bug 198533

Comment 8

[Boris Zbarsky [:bzbarsky]]

Fixed by checkin for bug 198533.