55806 - Text in angle brackets lost

Status: VERIFIED FIXED

(Core :: DOM: Serializers, defect, P1)

Description

[Ben Bucksch (:BenB)]

Reproduce:
1. Open HTML composer
2. Enter

The URL:
<http://www.zdnet.com/eweek/stories/general/0,11011,2637785,00.html>.

See <http://www.bucksch.org/1/projects/mozilla/dist/mozcom>. More info
soon, stay tuned.

3. Send (as plaintext)

Actual result:

The URL: .

See . More info soon, stay tuned.

Expected result:
Same as entered in 3..

Reproduce:
4. Open this bug on Mozilla.
5. Select the text to be entereed in step 3..
6. Paste in an textfield outside Mozilla, e.g. in 4.x.

Actual result:

The URL:
.

See . More info
soon, stay tuned.

(note the early linebreaks)

Expected result:
Same as to be entered in 3..

Comment 1

[Ben Bucksch (:BenB)]

Propably a regression due to bug 50742.

Please fix before M18. (No M18 keyword, ccing Asa instead.)

Comment 2

[Joe Francis]

ok, we know about this one.  Just looking for advice on whether jst's fix is the 
right one.

Comment 3

[Johnny Stenback (:jst)]

Attachment: Proposed fix

Comment 4

[Johnny Stenback (:jst)]

The attached patch fixes the problem by not using the entity converter that is
not meant to be used for what we tried using it for, in stead the serializer now
uses nsEscapeHTML2() which does the right thing.

Comment 5

[Ben Bucksch (:BenB)]

jst, thanks for fixing. Patch works for me. (This is no r=.)

If you have time, check if you can use |mozITXTToHTMLConv:ScanTXT| with param
whattodo == 0. It does the same, and is the "real" HTML->TXT converter, but I
don't know about the performance.

Comment 6

[Ben Bucksch (:BenB)]

s/HTML->TXT/TXT->HTML/

Comment 7

[Johnny Stenback (:jst)]

*** Bug 55711 has been marked as a duplicate of this bug. ***

Comment 8

[Nisheeth Ranjan]

According to jst, this bug, which was caused by the NOXIF checkin, has been
reviewed and approved by waterson.  RTM+'ing it for PDT approval.

Comment 9

[Johnny Stenback (:jst)]

Marking rtm++ per discussion with Jim (jar), this will go in as part of the
noxif carpool.

Comment 10

[Johnny Stenback (:jst)]

The fix for this was checked in with the noxif landing yesterday and today
(branch and trunk). Marking fixed

Comment 11

[Ben Bucksch (:BenB)]

verified with my Linux build from yesterday. Other platforms untested.

Comment 12

[sujay]

marking verified per Ben's comments.

Comment 13

[Ben Bucksch (:BenB)]

I checked the trunk build only.