Workers: Don't assume we always get a JSErrorReport in DOMWorkerErrorReporter

RESOLVED FIXED

Status

()

Core
DOM
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Ben Turner (not reading bugmail, use the needinfo flag!), Assigned: Ben Turner (not reading bugmail, use the needinfo flag!))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(status1.9.2 .4-fixed, status1.9.1 .10-fixed)

Details

Attachments

(1 attachment)

Blake is going to fix bug 557346 so that we should always have a ucmessage for every JSErrorReport, but we can sometimes not have a JSErrorReport. We should handle that case.
Created attachment 437949 [details] [diff] [review]
Patch
Attachment #437949 - Flags: review?(mrbkap)
Comment on attachment 437949 [details] [diff] [review]
Patch

r=me with those reinterpret_casts that you added.
Attachment #437949 - Flags: review?(mrbkap) → review+
http://hg.mozilla.org/mozilla-central/rev/94a52b6b6d4e
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Comment on attachment 437949 [details] [diff] [review]
Patch

I'd really like to get this on 1.9.2. It fixes the Error object to be useful from workers and has tests.
Attachment #437949 - Flags: approval1.9.2.4?
Attachment #437949 - Flags: approval1.9.1.10?
Comment on attachment 437949 [details] [diff] [review]
Patch

a=beltzner for 1.9.2.4 and 1.9.1.10; Al, should be verified by the automatic tests

bent: is there a manual testcase we can use to doublecheck? is that even needed?
Attachment #437949 - Flags: approval1.9.2.4?
Attachment #437949 - Flags: approval1.9.2.4+
Attachment #437949 - Flags: approval1.9.1.10?
Attachment #437949 - Flags: approval1.9.1.10+
No, no manual test needed.
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5029d40d15eb
status1.9.2: --- → .4-fixed
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9cb32a4624a6
status1.9.1: --- → .10-fixed
You need to log in before you can comment on or make changes to this bug.