558182 - Workers: Don't assume we always get a JSErrorReport in DOMWorkerErrorReporter

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Blake is going to fix bug 557346 so that we should always have a ucmessage for every JSErrorReport, but we can sometimes not have a JSErrorReport. We should handle that case.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 437949 [details] [diff] [review]
Patch

r=me with those reinterpret_casts that you added.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/mozilla-central/rev/94a52b6b6d4e

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 437949 [details] [diff] [review]
Patch

I'd really like to get this on 1.9.2. It fixes the Error object to be useful from workers and has tests.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 437949 [details] [diff] [review]
Patch

a=beltzner for 1.9.2.4 and 1.9.1.10; Al, should be verified by the automatic tests

bent: is there a manual testcase we can use to doublecheck? is that even needed?

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

No, no manual test needed.

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5029d40d15eb

Comment 8

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9cb32a4624a6