Last Comment Bug 558182 - Workers: Don't assume we always get a JSErrorReport in DOMWorkerErrorReporter
: Workers: Don't assume we always get a JSErrorReport in DOMWorkerErrorReporter
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Ben Turner (not reading bugmail, use the needinfo flag!)
:
Mentors:
Depends on: 557346
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-08 14:35 PDT by Ben Turner (not reading bugmail, use the needinfo flag!)
Modified: 2010-04-09 17:15 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
.4-fixed
.10-fixed


Attachments
Patch (5.02 KB, patch)
2010-04-08 14:37 PDT, Ben Turner (not reading bugmail, use the needinfo flag!)
mrbkap: review+
mbeltzner: approval1.9.2.4+
mbeltzner: approval1.9.1.10+
Details | Diff | Splinter Review

Description Ben Turner (not reading bugmail, use the needinfo flag!) 2010-04-08 14:35:57 PDT
Blake is going to fix bug 557346 so that we should always have a ucmessage for every JSErrorReport, but we can sometimes not have a JSErrorReport. We should handle that case.
Comment 1 Ben Turner (not reading bugmail, use the needinfo flag!) 2010-04-08 14:37:01 PDT
Created attachment 437949 [details] [diff] [review]
Patch
Comment 2 Blake Kaplan (:mrbkap) 2010-04-08 15:55:48 PDT
Comment on attachment 437949 [details] [diff] [review]
Patch

r=me with those reinterpret_casts that you added.
Comment 3 Ben Turner (not reading bugmail, use the needinfo flag!) 2010-04-08 16:04:02 PDT
http://hg.mozilla.org/mozilla-central/rev/94a52b6b6d4e
Comment 4 Ben Turner (not reading bugmail, use the needinfo flag!) 2010-04-08 16:04:44 PDT
Comment on attachment 437949 [details] [diff] [review]
Patch

I'd really like to get this on 1.9.2. It fixes the Error object to be useful from workers and has tests.
Comment 5 Mike Beltzner [:beltzner, not reading bugmail] 2010-04-09 13:23:36 PDT
Comment on attachment 437949 [details] [diff] [review]
Patch

a=beltzner for 1.9.2.4 and 1.9.1.10; Al, should be verified by the automatic tests

bent: is there a manual testcase we can use to doublecheck? is that even needed?
Comment 6 Ben Turner (not reading bugmail, use the needinfo flag!) 2010-04-09 13:37:48 PDT
No, no manual test needed.
Comment 7 Ben Turner (not reading bugmail, use the needinfo flag!) 2010-04-09 16:52:08 PDT
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5029d40d15eb
Comment 8 Ben Turner (not reading bugmail, use the needinfo flag!) 2010-04-09 17:15:13 PDT
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9cb32a4624a6

Note You need to log in before you can comment on or make changes to this bug.