558290 - Using the preferences dialog to open the add-ons manager it gets opened in a new dialog

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a4pre) Gecko/20100407 Minefield/3.7a4pre

Beside the option inside the Tools menu, you can also open the add-ons manager from within the preferences dialog. Using that way the manager gets opened in a new dialog.

I wonder why this button has been placed into the preferences a long time ago. Dave or Jennifer, do we know how how many people are using that button at all and if it is worth to further support it?

Comment 1

[Robert Strong (they/them - no direct email)]

The rationale given for why it needed to be available from options / preferences was that some users look in options / preferences when trying to configure add-ons. This is why the text states "Change options / preferences for your add-ons".

Comment 2

[Dave Townsend [:mossop]]

Should be easy to fix this but we probably need to do so before the trunk landing.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch

After some discussion on IRC, I've done a quick-n-dirty temporary fix for this - where it just opens a new browser window with about:addons in a tab.

A proper solution involved solving a lot of special cases, mainly to do with when the prefs dialog is modal. However, the prefs dialog is going to be re-designed and put in-content - meaning all that code would be ripped out soon anyway. So this will need to be re-visited when prefs gets its overhaul.

http://hg.mozilla.org/projects/addonsmgr/rev/cf9e539459d5

Comment 4

[Dave Townsend [:mossop]]

While you're here could you also fix the fact that the security page assumes that the usewhitelist pref exists?

Comment 5

[Dave Townsend [:mossop]]

Landed on trunk as a part of bug 554007

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a5pre) Gecko/20100511 Minefield/3.7a5pre ID:20100511030640 on all platforms.

Straight forward fix which doesn't need a manual test IMO. Blair, I believe the same applies to an automated test. If you disagree please update the flag.