Using the preferences dialog to open the add-ons manager it gets opened in a new dialog

VERIFIED FIXED in mozilla1.9.3a5

Status

()

defect
P1
normal
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: whimboo, Assigned: Unfocused)

Tracking

Trunk
mozilla1.9.3a5
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [rewrite])

Attachments

(1 attachment)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a4pre) Gecko/20100407 Minefield/3.7a4pre

Beside the option inside the Tools menu, you can also open the add-ons manager from within the preferences dialog. Using that way the manager gets opened in a new dialog.

I wonder why this button has been placed into the preferences a long time ago. Dave or Jennifer, do we know how how many people are using that button at all and if it is worth to further support it?
The rationale given for why it needed to be available from options / preferences was that some users look in options / preferences when trying to configure add-ons. This is why the text states "Change options / preferences for your add-ons".
Should be easy to fix this but we probably need to do so before the trunk landing.
Priority: -- → P1
Assignee: nobody → bmcbride
Posted patch PatchSplinter Review
After some discussion on IRC, I've done a quick-n-dirty temporary fix for this - where it just opens a new browser window with about:addons in a tab.

A proper solution involved solving a lot of special cases, mainly to do with when the prefs dialog is modal. However, the prefs dialog is going to be re-designed and put in-content - meaning all that code would be ripped out soon anyway. So this will need to be re-visited when prefs gets its overhaul.

http://hg.mozilla.org/projects/addonsmgr/rev/cf9e539459d5
Attachment #440661 - Flags: review?
Status: NEW → ASSIGNED
Whiteboard: [rewrite] → [rewrite][fixed-in-addonsmgr]
While you're here could you also fix the fact that the security page assumes that the usewhitelist pref exists?
Landed on trunk as a part of bug 554007
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Whiteboard: [rewrite][fixed-in-addonsmgr] → [rewrite]
Target Milestone: --- → mozilla1.9.3a5
Attachment #440661 - Flags: review?
Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a5pre) Gecko/20100511 Minefield/3.7a5pre ID:20100511030640 on all platforms.

Straight forward fix which doesn't need a manual test IMO. Blair, I believe the same applies to an automated test. If you disagree please update the flag.
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Flags: in-litmus-
Keywords: uiwanted
You need to log in before you can comment on or make changes to this bug.