Closed Bug 558313 Opened 10 years ago Closed 8 years ago

ipc/chromium/src/base/third_party duplicates code that is already in the mozilla code base

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: glandium, Assigned: Ms2ger)

Details

Attachments

(1 file)

ipc/chromium/src/base/third_party/nspr and ipc/chromium/src/base/third_party/nss contain copies of things that can be found in nss and nspr

ipc/chromium/src/base/third_party/dmg_fp contains yet another copy of dtoa, which can already be found in the javascript engine source code, and in nspr, too.
Assignee: nobody → Ms2ger
Attached patch Patch v1Splinter Review
Attachment #627118 - Flags: review?(ted.mielczarek)
Comment on attachment 627118 [details] [diff] [review]
Patch v1

Review of attachment 627118 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a big fan of this.

::: mozglue/android/Makefile.in
@@ +64,5 @@
>  
>  include $(topsrcdir)/config/rules.mk
> +
> +prcpucfg.h:
> +	cp $(topsrcdir)/nsprpub/pr/include/md/_linux.cfg prcpucfg.h

Could probably use $(INSTALL) or something here to get it symlinked.
Attachment #627118 - Flags: review?(ted.mielczarek) → review+
(In reply to Ted Mielczarek [:ted] from comment #3)
> > +prcpucfg.h:
> > +	cp $(topsrcdir)/nsprpub/pr/include/md/_linux.cfg prcpucfg.h
> 
> Could probably use $(INSTALL) or something here to get it symlinked.

Unfortunately, $(INSTALL) doesn't allow a file target, and thus doesn't allow to rename.

This could use dependencies, though:

prcpucfg.h: $(topsrcdir)/nsprpub/pr/include/md/_linux.cfg
        cp $< $@
https://hg.mozilla.org/mozilla-central/rev/579d084b544e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.