ipc/chromium/src/base/third_party duplicates code that is already in the mozilla code base

RESOLVED FIXED in mozilla16

Status

()

Core
IPC
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: glandium, Assigned: Ms2ger)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
ipc/chromium/src/base/third_party/nspr and ipc/chromium/src/base/third_party/nss contain copies of things that can be found in nss and nspr

ipc/chromium/src/base/third_party/dmg_fp contains yet another copy of dtoa, which can already be found in the javascript engine source code, and in nspr, too.
(Assignee)

Updated

5 years ago
Assignee: nobody → Ms2ger
(Assignee)

Comment 1

5 years ago
Created attachment 627118 [details] [diff] [review]
Patch v1
Attachment #627118 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 2

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=52c4e0edb8ca
Comment on attachment 627118 [details] [diff] [review]
Patch v1

Review of attachment 627118 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a big fan of this.

::: mozglue/android/Makefile.in
@@ +64,5 @@
>  
>  include $(topsrcdir)/config/rules.mk
> +
> +prcpucfg.h:
> +	cp $(topsrcdir)/nsprpub/pr/include/md/_linux.cfg prcpucfg.h

Could probably use $(INSTALL) or something here to get it symlinked.
Attachment #627118 - Flags: review?(ted.mielczarek) → review+
(Reporter)

Comment 4

5 years ago
(In reply to Ted Mielczarek [:ted] from comment #3)
> > +prcpucfg.h:
> > +	cp $(topsrcdir)/nsprpub/pr/include/md/_linux.cfg prcpucfg.h
> 
> Could probably use $(INSTALL) or something here to get it symlinked.

Unfortunately, $(INSTALL) doesn't allow a file target, and thus doesn't allow to rename.

This could use dependencies, though:

prcpucfg.h: $(topsrcdir)/nsprpub/pr/include/md/_linux.cfg
        cp $< $@
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/579d084b544e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.