558313 - ipc/chromium/src/base/third_party duplicates code that is already in the mozilla code base

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Mike Hommey [:glandium]]

ipc/chromium/src/base/third_party/nspr and ipc/chromium/src/base/third_party/nss contain copies of things that can be found in nss and nspr

ipc/chromium/src/base/third_party/dmg_fp contains yet another copy of dtoa, which can already be found in the javascript engine source code, and in nspr, too.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://tbpl.mozilla.org/?tree=Try&rev=52c4e0edb8ca

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 627118 [details] [diff] [review]
Patch v1

Review of attachment 627118 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a big fan of this.

::: mozglue/android/Makefile.in
@@ +64,5 @@
>  
>  include $(topsrcdir)/config/rules.mk
> +
> +prcpucfg.h:
> +	cp $(topsrcdir)/nsprpub/pr/include/md/_linux.cfg prcpucfg.h

Could probably use $(INSTALL) or something here to get it symlinked.

Comment 4

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted] from comment #3)
> > +prcpucfg.h:
> > +	cp $(topsrcdir)/nsprpub/pr/include/md/_linux.cfg prcpucfg.h
> 
> Could probably use $(INSTALL) or something here to get it symlinked.

Unfortunately, $(INSTALL) doesn't allow a file target, and thus doesn't allow to rename.

This could use dependencies, though:

prcpucfg.h: $(topsrcdir)/nsprpub/pr/include/md/_linux.cfg
        cp $< $@

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/579d084b544e