Last Comment Bug 558313 - ipc/chromium/src/base/third_party duplicates code that is already in the mozilla code base
: ipc/chromium/src/base/third_party duplicates code that is already in the mozi...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: IPC (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-09 06:57 PDT by Mike Hommey [:glandium]
Modified: 2012-06-06 03:18 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (133.25 KB, patch)
2012-05-25 00:26 PDT, :Ms2ger (⌚ UTC+1/+2)
ted: review+
Details | Diff | Splinter Review

Description Mike Hommey [:glandium] 2010-04-09 06:57:32 PDT
ipc/chromium/src/base/third_party/nspr and ipc/chromium/src/base/third_party/nss contain copies of things that can be found in nss and nspr

ipc/chromium/src/base/third_party/dmg_fp contains yet another copy of dtoa, which can already be found in the javascript engine source code, and in nspr, too.
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2012-05-25 00:26:16 PDT
Created attachment 627118 [details] [diff] [review]
Patch v1
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-05-25 00:26:34 PDT
https://tbpl.mozilla.org/?tree=Try&rev=52c4e0edb8ca
Comment 3 Ted Mielczarek [:ted.mielczarek] 2012-05-25 12:32:20 PDT
Comment on attachment 627118 [details] [diff] [review]
Patch v1

Review of attachment 627118 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a big fan of this.

::: mozglue/android/Makefile.in
@@ +64,5 @@
>  
>  include $(topsrcdir)/config/rules.mk
> +
> +prcpucfg.h:
> +	cp $(topsrcdir)/nsprpub/pr/include/md/_linux.cfg prcpucfg.h

Could probably use $(INSTALL) or something here to get it symlinked.
Comment 4 Mike Hommey [:glandium] 2012-05-25 13:26:32 PDT
(In reply to Ted Mielczarek [:ted] from comment #3)
> > +prcpucfg.h:
> > +	cp $(topsrcdir)/nsprpub/pr/include/md/_linux.cfg prcpucfg.h
> 
> Could probably use $(INSTALL) or something here to get it symlinked.

Unfortunately, $(INSTALL) doesn't allow a file target, and thus doesn't allow to rename.

This could use dependencies, though:

prcpucfg.h: $(topsrcdir)/nsprpub/pr/include/md/_linux.cfg
        cp $< $@
Comment 5 :Ms2ger (⌚ UTC+1/+2) 2012-06-06 03:18:16 PDT
https://hg.mozilla.org/mozilla-central/rev/579d084b544e

Note You need to log in before you can comment on or make changes to this bug.