558374 - MAPILogon causes crash if a profile name is supplied but password is set to NULL [@ nsMAPISession::nsMAPISession]

Status: RESOLVED INCOMPLETE

(MailNews Core :: Simple MAPI, defect)

Description

[jon]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 (.NET CLR 3.5.30729)
Build Identifier: Thunderbird/3.0.4

Calling MAPILogon with the profile parameter set to non-NULL ie. a valid profile and the password set to NULL causes a program crash.

Reproducible: Always

Steps to Reproduce:
1. Call MAPILogon ( 0L, "jon", NULL, MAPI_LOGON_UI, 0L, &hSession ) ;
2.
3.
Actual Results:  
Program crash (access violation at 0)

Expected Results:  
Logon returns valid error code.

At a guess, suspect it's probably in msgMapiMain.cpp:

nsMAPISession::nsMAPISession(PRUint32 aHwnd, const PRUnichar *aUserName,
                             const PRUnichar *aPassword, 
                             PRBool aForceDownLoad, const char *aKey)
: m_bIsForcedDownLoad(aForceDownLoad),
  m_hAppHandle(aHwnd),
  m_nShared(1),
  m_pIdKey(aKey)
{
  m_listContext = NULL;
  m_pProfileName.Assign(aUserName);
  m_pPassword.Assign(aPassword);
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^

Comment 1

[Wayne Mery (:wsmwk)]

(severity)

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.

Comment 3

[Wayne Mery (:wsmwk)]

No crashes containing nsMAPISession in last 6 months.
But needs to be retested

Comment 4

[Gaylord Baron]

Manipulation to reproduce:

• Mozilla Thunderbird installed (60.4.0 (32 bit)).
• Thunderbird set as the default application.
• Call MAPILogon (0L, "jon", NULL, MAPI_LOGON_UI, 0L, & hSession); => it works
• Install the latest version of Office 2016, for example with the Office Deployment Tool. (our version: 16.0.11126.20266)
• Call MAPILogon (0L, "jon", NULL, MAPI_LOGON_UI, 0L, & hSession);
  => Application crash

Borderline Workaround:
rename the following file:
C: \ Program Files (x86) \ Microsoft Office \ Root \ vfs \ ProgramFilesCommonX86 \ SYSTEM \ MSMAPI \ 1036 \ MSMAPI32.dll

The application will not crash anymore.

Comment 5

[Jorg K (CEST = GMT+2)]

Could you retest with TB 68.2.2 please. Also, which application uses MAPILogon()? It's quite possible that this doesn't work, see bug 1521380.

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to Jorg K (GMT+1) (PTO to 1st Dec 2019, not reading bugmail) from comment #5)

Could you retest with TB 68.2.2 please. Also, which application uses MAPILogon()? It's quite possible that this doesn't work, see bug 1521380.

This quesiton will be for Gayloard ^ (the reporter is gone)

Comment 7

[Phoenix]

Resolved per whiteboard