Closed Bug 558437 Opened 12 years ago Closed 12 years ago

rename JSCompiler to js::Parser

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dherman, Assigned: dherman)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(2 files, 3 obsolete files)

Parsing and compilation are tangled up in one disorganized JSCompiler class. This class is almost entirely the parser, so should be renamed as such. I'll submit a separate bug to separate out the compileXXX static methods into a separate js::Compiler class.

Dave
This was the smallest patch I could get working by the end of the day so Brendan could work on the parser. If this is accepted, it'd be good to move js::Compiler out to new jscompile.{cpp,h} files.

Dave
Attachment #438210 - Flags: review?(brendan)
Depends on: 558002
I forgot to mention! You need to apply cdleary's patch from bug 558002 before applying this patch.

Dave
Fixed little conflicts against against the review changes because I was in there anyway.
Attachment #438210 - Attachment is obsolete: true
Attachment #438229 - Flags: review?(brendan)
Attachment #438210 - Flags: review?(brendan)
Renamed a few mistaken Parser::compileFoo comments to Compiler::compileFoo.

Updated to this morning's tracemonkey tree (and resolved patch conflicts).

***No longer requires cdleary's patch (bug 558002) since that's been committed.***

Dave
Attachment #438229 - Attachment is obsolete: true
Attachment #438268 - Flags: review?(brendan)
Attachment #438229 - Flags: review?(brendan)
Attached patch patch to commitSplinter Review
Rebased and with a few cosmetic nits picked.

/be
Attachment #438268 - Attachment is obsolete: true
Attachment #438307 - Flags: review+
Attachment #438268 - Flags: review?(brendan)
http://hg.mozilla.org/tracemonkey/rev/341ffe867ea8

/be
Status: NEW → ASSIGNED
Whiteboard: fixed-in-tracemonkey
Bugzilla interdiff failed.

The style for Compiler::init is like we use for method and function definitions outside of a class body, but it's of course inline. It could use the more concise inline style, with return type, declarator, and left brace all on one line, but it has a lot of args, and the next two declarations are big and use outside-the-class style, so it seems better to blend.

/be
Blocks: 533874
http://hg.mozilla.org/mozilla-central/rev/341ffe867ea8
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.