558437 - rename JSCompiler to js::Parser

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Dave Herman [:dherman]]

Parsing and compilation are tangled up in one disorganized JSCompiler class. This class is almost entirely the parser, so should be renamed as such. I'll submit a separate bug to separate out the compileXXX static methods into a separate js::Compiler class.

Dave

Comment 1

[Dave Herman [:dherman]]

Attachment: renames JSCompiler to js::Parser, moves compilation methods to js::Compiler

This was the smallest patch I could get working by the end of the day so Brendan could work on the parser. If this is accepted, it'd be good to move js::Compiler out to new jscompile.{cpp,h} files.

Dave

Comment 2

[Dave Herman [:dherman]]

I forgot to mention! You need to apply cdleary's patch from bug 558002 before applying this patch.

Dave

Comment 3

[Chris Leary [:cdleary] (not checking bugmail)]

Attachment: renames JSCompiler to js::Parser, moves compilation methods to js::Compiler

Fixed little conflicts against against the review changes because I was in there anyway.

Comment 4

[Dave Herman [:dherman]]

Attachment: renames JSCompiler to js::Parser, moves compilation methods to js::Compiler

Renamed a few mistaken Parser::compileFoo comments to Compiler::compileFoo.

Updated to this morning's tracemonkey tree (and resolved patch conflicts).

***No longer requires cdleary's patch (bug 558002) since that's been committed.***

Dave

Comment 5

[Brendan Eich [:brendan]]

Attachment: patch to commit

Rebased and with a few cosmetic nits picked.

/be

Comment 6

[Brendan Eich [:brendan]]

http://hg.mozilla.org/tracemonkey/rev/341ffe867ea8

/be

Comment 7

[Brendan Eich [:brendan]]

Attachment: interdiff of last two patches

Bugzilla interdiff failed.

The style for Compiler::init is like we use for method and function definitions outside of a class body, but it's of course inline. It could use the more concise inline style, with return type, declarator, and left brace all on one line, but it has a lot of args, and the next two declarations are big and use outside-the-class style, so it seems better to blend.

/be

Comment 8

[Brendan Eich [:brendan]]

Argh:

http://hg.mozilla.org/tracemonkey/rev/91ca703f8d69

/be

Comment 9

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/341ffe867ea8