558461 - Firefox asks a confirmation message when trying to close just one tab: "You are about to close 1 tab. Are you sure you want to continue?"

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Chamath Mc]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 (.NET CLR 3.5.30729)

Usually when the user tries to close a series of tabs, user is warned as "You are about to close x tabs. Are you sure you want to continue?"
Bottom of the message you can see "Warn me when I attempt to close multiple tabs".
This message is supposed to be only when closing multiple tabs. But there is a minor bug where it gives a warning when you try to close 1 tab.

Reproducible: Always

Steps to Reproduce:
1.Open firefox browser and keep 2 tabs open.

2. Right click on one tab and click "Close other tabs".
Actual Results:  
User gets a message saying "You are about to close 1 tab. Are you sure you want to continue?" On the bottom of the message still you can see "Warn me when I attempt to close multiple tabs" check box already checked.

Expected Results:  
Got a message saying "You are about to close 1 tab. Are you sure you want to continue?" On the bottom of the message still you can see "Warn me when I attempt to close multiple tabs" check box already checked.

Either:
The message stating "You are about to close 1 tab" should not be displayed,

OR

There should not be a checkbox at the bottom of the message saying "Warn me when I try to close multiple tabs" since it does not match with the user's action of closing one tab.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.4pre) Gecko/20100410 Namoroka/3.6.4pre

Comment 2

[Dão Gottwald [:dao]]

Attachment: don't warn when closing one tab

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 438342 [details] [diff] [review]
don't warn when closing one tab

Can you replace the two first uses of "reallyClose" with "true" while you're at it? Makes things clearer IMO.

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> Can you replace the two first uses of "reallyClose" with "true" while you're at
> it? Makes things clearer IMO.

done.

http://hg.mozilla.org/mozilla-central/rev/b9e9ae011ce4