558476 - Fennec awesomebar results are not as awesome as they could be

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Benjamin Stover (:stechz)]

We are forgetting to call a couple things at the right times:
MarkPageAsFollowedLink
MarkPageAsFollowedBookmark

These determine the transition type in the moz_historyvisits table--which determines frecency.

Comment 1

[Benjamin Stover (:stechz)]

CC'd a few places peeps.

mfinkle pointed out that MarkPageAsFollowedLink is not even called by desktop Firefox O_o

Comment 2

[Marco Bonardo [:mak]]

(In reply to comment #1)
> CC'd a few places peeps.
> 
> mfinkle pointed out that MarkPageAsFollowedLink is not even called by desktop
> Firefox O_o

this has been implemented recently and we still have to hook it into browser code. will be done after bug 549340. This is currently useful only for visits across framed websites though.

Comment 3

[Marco Bonardo [:mak]]

(In reply to comment #2)
> this has been implemented recently and we still have to hook it into browser
> code. will be done after bug 549340. This is currently useful only for visits
> across framed websites though.

just to better clarify, we will call markPageAsFollowedLink at the end of the new contentAreaClick, doing so Places will know that link comes from a guessed user interaction, thus in a framed page we will save the visit across frames persistently instead as only for the session (that is what happens right now) and link coloring will be preserved across sessions for those links. This is the only reason atm.

markPageAsFollowedBookmark is instead called when clicking on bookmarks in Places views iirc.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #3)

> just to better clarify, we will call markPageAsFollowedLink at the end of the
> new contentAreaClick, doing so Places will know that link comes from a guessed
> user interaction, thus in a framed page we will save the visit across frames
> persistently instead as only for the session (that is what happens right now)
> and link coloring will be preserved across sessions for those links. This is
> the only reason atm.

Fennec can probably find a good spot to call this function as well.

> markPageAsFollowedBookmark is instead called when clicking on bookmarks in
> Places views iirc.

This will be easy for Fennec to use as well.

Comment 5

[BMO Automation]

Closing all opened bug in a graveyard component