558489 - [OOPP] Minefield autoreleasing NSThread objects with no pool in place

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Steven Michaud [:smichaud] (Retired)]

Recent Minefield nightlies always display the following error in the
console on startup:

*** _NSAutoreleaseNoPool():
  Object 0x6148a0 of class NSThread autoreleased with no pool in place
  - just leaking

Here's the regression range:

firefox-2010-04-02-03-mozilla-central
http://hg.mozilla.org/mozilla-central/rev/c8f0660250e0
firefox-2010-04-03-03-mozilla-central
http://hg.mozilla.org/mozilla-central/rev/53b8f71cd21e

http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2010-04-02&enddate=2010-04-03+06%3A00%3A00

This probably implicates the patch for bug 555234.

In my next comment I'll post a gdb trace of the error.

Comment 1

[Steven Michaud [:smichaud] (Retired)]

Attachment: gdb trace of error

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Forgot to mention that this error happens on both OS X 10.6.3 and 10.5.8.

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: prevent autorelease-leakage during ipc startup

base::InitThreading() is called very early in startup, before we have any pools in place. The chromium code provides a stack-based autorelease pool helper, so we can simply use that here.

Comment 4

[Jonathan Kew [:jfkthame]]

http://hg.mozilla.org/mozilla-central/rev/255ffcdf73a1