558490 - e10s HTTP: infrastructure to implement SetPriority

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Jason Duell]

Attachment: infrastructure for SetPriority

The attached patch implements 95% of what we need for SetPriority in e10s.  It implements SetPriority in HttpChannelChild, and sets it correctly in AsyncOpen.

All that's missing is setting priority after AsyncOpen.  This has the logic to 
send an IPDL msg to the Parent, but since we haven't yet figured out the "correct" way to keep a ref to the underlying nsHttpChannel in the parent, we don't do anything with the value.

Will file a followup bug--I want this to land, because it appears to be the last piece needed to get testXul bootstrapped.

Comment 1

[[e-mail]]

Comment on attachment 438214 [details] [diff] [review]
infrastructure for SetPriority

>diff --git a/netwerk/protocol/http/src/HttpChannelChild.cpp b/netwerk/protocol/http/src/HttpChannelChild.cpp
>@@ -75,17 +75,16 @@ NS_INTERFACE_MAP_BEGIN(HttpChannelChild)

>-  NS_INTERFACE_MAP_ENTRY(nsISupportsPriority)

I don't think you want that, otherwise HttpChannelChild won't be QI'able to nsISupportsPriority.

>-NS_IMETHODIMP
>-HttpChannelChild::AdjustPriority(PRInt32 delta)
>-{
>-  DROP_DEAD();
>+  PRInt16 newValue = CLAMP(aPriority, PR_INT16_MIN, PR_INT16_MAX);
>+  if (mPriority == newValue)
>+    return NS_OK;
>+  mPriority = newValue;
>+  if (mWasOpened) {
>+    if (!SendSetPriority(mPriority)) {
>+      // IPDL error: our destructor will be called automatically
>+      // -- TODO: verify that that's the case

No need to check the rv here, if the Send call fails the process aborts.

>diff --git a/netwerk/protocol/http/src/HttpChannelParent.cpp b/netwerk/protocol/http/src/HttpChannelParent.cpp

>+bool 
>+HttpChannelParent::RecvSetPriority(const PRUint16& priority)
>+{
>+  // FIXME: bug XXX: once we figure out how to keep a ref to the nsHttpChannel,
>+  // call SetPriority on it here.

OT -- can't we make HttpChannelParent inherit from nsHttpChannel?

>diff --git a/netwerk/protocol/http/src/nsHttpChannel.cpp b/netwerk/protocol/http/src/nsHttpChannel.cpp
>@@ -4000,17 +3999,16 @@ NS_INTERFACE_MAP_BEGIN(nsHttpChannel)

>-    NS_INTERFACE_MAP_ENTRY(nsISupportsPriority)

Same comment here.

r=dwitte with fixes

Comment 2

[Jason Duell]

http://hg.mozilla.org/projects/electrolysis/rev/3caeea7ad091