Closed
Bug 558520
Opened 14 years ago
Closed 14 years ago
Stop trying to link libplaces.dylib in shared builds
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alqahira, Assigned: alqahira)
Details
Attachments
(1 file)
3.70 KB,
patch
|
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
code is smarter than I am; it knows that libplaces.dylib is a component, not a shared library, so it spits out a not-very-helpful warning every shared build and helpfully does not link libplaces.dylib: Checking Dependencies... warning: skipping file '/builds/tinderbox/Cm2.1-M1.9-perf/Darwin_8.11.0_Depend/build/camino/../dist/bin/components/libplaces.dylib' (unexpected file type 'compiled.mach-o.bundle' in Frameworks & Libraries build phase) At some point I thought I had seen a -lplaces in the linker commands, but maybe I was confusing shared with static? At any rate, I've verified on both 1.9.0 and 1.9.2 that this patch makes no noticeable behavioral difference in history; it just kills the warning.
Attachment #438235 -
Flags: superreview?(stuart.morgan+bugzilla)
Comment 1•14 years ago
|
||
> it knows that libplaces.dylib is a component, not a shared library
What does that mean, exactly? I'm not clear why we wouldn't want to link libplaces in shared. Is it not built?
Assignee | ||
Comment 2•14 years ago
|
||
In shared, we don't link anything in dist/bin/components; we only link the full-fledged libraries (NSPR, NSS, XPCOM, Thebes, etc.) from dist/Embed (dist/bin in 1.9.2), and their content-types are "compiled.mach-o.dylib", not "compiled.mach-o.bundle". Open the project and look at the link phase in shared, and then compare the contents with the list of stand-alone items in "Gecko" and "Gecko Components"; note other than libthebes (which Xcode is refusing to link, anyway), there are no items in "Gecko Components" in the shared build's link step; they all come from the "Gecko" group (or the NSS group). Again, Xcode is and has been refusing to link libthebes.dylib since it's not a real shared library; all this does is make us stop telling Xcode to try to link it, and kill the warning.
Comment 3•14 years ago
|
||
Comment on attachment 438235 [details] [diff] [review] Fix Okie, sr=smorgan
Attachment #438235 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Assignee | ||
Comment 4•14 years ago
|
||
Landed on cvs trunk and http://hg.mozilla.org/camino/rev/a040e63e95b0
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•