Build broken in libpr0n due to empty includes (vector/algorithm)

VERIFIED DUPLICATE of bug 557000

Status

VERIFIED DUPLICATE of bug 557000
9 years ago
8 months ago

People

(Reporter: bugmail, Unassigned)

Tracking

({regression})

Trunk
All
FreeBSD
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Created attachment 438283 [details] [diff] [review]
GCC_VERSION patch v1 (mozilla-central)

Builds on FreeBSD have been broken for about a week. The error message includes:
../../../dist/stl_wrappers/vector:92:12: error: empty filename in #include
../../../dist/stl_wrappers/algorithm:92:12: error: empty filename in #include

The build falsely assumes that MSVC is being used because GCC_VERSION isn't set.
The attached patch should unbreak the build for every non-tier-1 platform that
uses GCC (with the possible exception of SGI's Irix which had GCC_VERSION set
already).

It would be nice to get some feedback from builders using the Intel compiler on
Linux. I hope this patch doesn't cause any problems using said configuration.
Deferring review request until we can be sure this is not the case.
(Reporter)

Updated

9 years ago
Blocks: 551254, 352822
Keywords: regression
Attachment #438283 - Attachment is patch: true
Attachment #438283 - Attachment mime type: application/octet-stream → text/plain
Is this issue different than bug 557000?
(Reporter)

Comment 2

9 years ago
It's indeed the same issue. And attachment 437811 [details] [diff] [review] from bug 557000 will probably  fix it for all platforms once it gets r+ and lands. Thanks for asking, Serge. :-)
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 557000
V.Duplicate
No longer blocks: 551254
Status: RESOLVED → VERIFIED
No longer blocks: 352822

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.