Closed
Bug 558598
Opened 15 years ago
Closed 15 years ago
XUL splitters should be collapsed on the correct side in RTL mode
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Keywords: rtl)
Attachments
(1 file, 1 obsolete file)
|
7.49 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Inside RTL mode, XUL splitters should be collapsed on the right side if collapse="before", on the left side if collapse="after" or on both sides if collapse="both".
Currently they're collapsed on the left side if collapse="before" and on the right side if collapse="after".
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #438292 -
Flags: review?(roc)
Comment on attachment 438292 [details] [diff] [review]
Patch (v1)
test?
Attachment #438292 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
The code is the same as attachment 438292 [details] [diff] [review]; I've just added a test for LTR and RTL collapse behavior of splitters.
Attachment #438292 -
Attachment is obsolete: true
Attachment #438383 -
Flags: review?(roc)
Attachment #438383 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
I made the xul:window inside the test orient=horizontal, to make sure that both hbox's fit on the screen, otherwise the RTL tests would fail.
|
|
Assignee | |
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in
before you can comment on or make changes to this bug.
Description
•