Closed Bug 558598 Opened 10 years ago Closed 10 years ago

XUL splitters should be collapsed on the correct side in RTL mode

Categories

(Core :: XUL, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

(Keywords: rtl)

Attachments

(1 file, 1 obsolete file)

Inside RTL mode, XUL splitters should be collapsed on the right side if collapse="before", on the left side if collapse="after" or on both sides if collapse="both".

Currently they're collapsed on the left side if collapse="before" and on the right side if collapse="after".
Attached patch Patch (v1) (obsolete) — Splinter Review
Attachment #438292 - Flags: review?(roc)
The code is the same as attachment 438292 [details] [diff] [review]; I've just added a test for LTR and RTL collapse behavior of splitters.
Attachment #438292 - Attachment is obsolete: true
Attachment #438383 - Flags: review?(roc)
I made the xul:window inside the test orient=horizontal, to make sure that both hbox's fit on the screen, otherwise the RTL tests would fail.
http://hg.mozilla.org/mozilla-central/rev/ae4590f7184e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.