|
2.35 KB,
patch
|
Misak Khachatryan
:
review+
Misak Khachatryan
:
superreview+
|
Details | Diff | Splinter Review |
Created attachment 438332 [details] [diff] [review] patch From parent bug: nsIWindowMediator tracks windows until they are destroyed, but there's a brief period when windows are closed without being destroyed yet. Session restore should only care for windows that are open and should thus skip windows that aren't. I don't think this is relevant for real users, but it likely is relevant for tests and could in fact be the cause for some intermittent failures we're seeing. I ran test on my Fedora 12, no failed test seen.
|
||
Updated•7 years ago
|
||
|
|
||
Comment 1•7 years ago
|
||
Comment on attachment 438332 [details] [diff] [review] patch >- if (window.__SSi) { >+ if (window.__SSi && !window.closed) { Window closing is supposed to delete properties. But just in case, I'd prefer for you to check !window.closed first.
|
(Assignee) | |
Comment 2•7 years ago
|
||
Created attachment 438370 [details] [diff] [review] for checkin For checkin, carrying forward r+ and sr+ from Neil.
|
|
(Assignee) | |
Updated•7 years ago
|
||
|
|
(Assignee) | |
Comment 3•7 years ago
|
||
checking ping
|
|
(Assignee) | |
Comment 4•7 years ago
|
||
Pushed http://hg.mozilla.org/comm-central/rev/5a33b560c2d5
|
|
(Assignee) | |
Updated•7 years ago
|
||
Description
•