Closed Bug 558639 Opened 15 years ago Closed 14 years ago

Port Bug 531519 [getBrowserState sometimes returns two entries for one window] to Seamonkey

Categories

(SeaMonkey :: Session Restore, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1a1

People

(Reporter: misak.bugzilla, Assigned: misak.bugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patchSplinter Review
From parent bug: http://hg.mozilla.org/mozilla-central/rev/4a7f5376270a exposed a constant failure on all platforms: TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_526613.js | number of open browser windows according to getBrowserState - Got 3, expected 2 This happens even when running browser_526613.js alone. I think the second window (from _windows) and the third one (from _statesToRestore) are the same, but I'm not sure. I ran test on my Fedora 12, no failed test seen.
Attachment #438335 - Flags: superreview?(neil)
Attachment #438335 - Flags: review?(neil)
Comment on attachment 438335 [details] [diff] [review] patch >+ if (this._windows[ix]._restoring) // window data is still in _statesToRestore >+ continue; Does checking (this._windows[ix].__SS_restoreID in this._statesToRestore) work? (That would avoid adding the extra _restoring flag.)
Attached patch patch v2 (obsolete) — Splinter Review
Well, seems to work, but as our browser_526613.js didn't fail on my Fedora 12, I'm requesting feedback from Dão Gottwald, maybe he can add useful comment here.
Attachment #438335 - Attachment is obsolete: true
Attachment #438368 - Flags: superreview?(neil)
Attachment #438368 - Flags: review?(neil)
Attachment #438368 - Flags: feedback?(dao)
Attachment #438335 - Flags: superreview?(neil)
Attachment #438335 - Flags: review?(neil)
Comment on attachment 438368 [details] [diff] [review] patch v2 Let's prefer to go with this version if possible.
Attachment #438368 - Flags: superreview?(neil)
Attachment #438368 - Flags: superreview+
Attachment #438368 - Flags: review?(neil)
Attachment #438368 - Flags: review+
Keywords: checkin-needed
Comment on attachment 438368 [details] [diff] [review] patch v2 Looks wrong to me. __SS_restoreID is set on dom windows, this._windows[ix] is not a dom window.
Attachment #438368 - Flags: feedback?(dao) → feedback-
Attachment #438368 - Attachment is obsolete: true
Comment on attachment 438335 [details] [diff] [review] patch Thank You very much Dão, unobsoleting previous patch and setting r+ and sr+, as discussed with Neil on IRC.
Attachment #438335 - Attachment is obsolete: false
Attachment #438335 - Flags: superreview+
Attachment #438335 - Flags: review+
checking ping
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
Hmm, looks like i checked in wrong patch ...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 15 years ago14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: