Persona is no longer an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 558652 - Port Bug 500328 [Add support for HTML5 History.pushState(), History.replaceState() methods] sessionstore parts to SeaMonkey
: Port Bug 500328 [Add support for HTML5 History.pushState(), History.replaceSt...
Product: SeaMonkey
Classification: Client Software
Component: Session Restore (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1a1
Assigned To: Misak Khachatryan
Depends on: 500328
  Show dependency treegraph
Reported: 2010-04-11 05:35 PDT by Misak Khachatryan
Modified: 2011-03-09 06:00 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch plus test (11.15 KB, patch)
2010-04-11 05:35 PDT, Misak Khachatryan
neil: review+
neil: superreview+
Details | Diff | Splinter Review
for checkin (11.13 KB, patch)
2010-04-11 22:17 PDT, Misak Khachatryan
misak.bugzilla: review+
misak.bugzilla: superreview+
Details | Diff | Splinter Review

Description Misak Khachatryan 2010-04-11 05:35:37 PDT
Created attachment 438352 [details] [diff] [review]
patch plus test

Tests passing in my Fedora 12
Comment 1 2010-04-11 09:55:22 PDT
Comment on attachment 438352 [details] [diff] [review]
patch plus test

>-    aWindow.setTimeout(function(){ _this.restoreHistory(aWindow, aTabs, aTabData, aIdMap); }, 0);
>+    aWindow.setTimeout(function(){
[Since you're changing it, it would be nice to have a space before the { ]

>+      let ident = aDocIdentMap[aEntry.docIdentifier];
>+      if (!ident) {
[This will generate a JS strict warning if there is no entry in the map yet. The easiest workaround is not to use the temporary ident variable.]
Comment 2 Misak Khachatryan 2010-04-11 22:17:35 PDT
Created attachment 438416 [details] [diff] [review]
for checkin

Neil nits fixed.
Comment 3 Misak Khachatryan 2010-04-11 22:18:03 PDT
Forgot mention, carrying forward r+ sr+ from Neil
Comment 4 Misak Khachatryan 2010-04-17 06:04:44 PDT
checking ping
Comment 5 Misak Khachatryan 2010-04-20 00:14:45 PDT

Note You need to log in before you can comment on or make changes to this bug.