The default bug view has changed. See this FAQ.

Port Bug 500328 [Add support for HTML5 History.pushState(), History.replaceState() methods] sessionstore parts to SeaMonkey

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Session Restore
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Misak Khachatryan, Assigned: Misak Khachatryan)

Tracking

Trunk
seamonkey2.1a1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

11.13 KB, patch
Misak Khachatryan
: review+
Misak Khachatryan
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Created attachment 438352 [details] [diff] [review]
patch plus test

Tests passing in my Fedora 12
Attachment #438352 - Flags: superreview?(neil)
Attachment #438352 - Flags: review?(neil)

Comment 1

7 years ago
Comment on attachment 438352 [details] [diff] [review]
patch plus test

>-    aWindow.setTimeout(function(){ _this.restoreHistory(aWindow, aTabs, aTabData, aIdMap); }, 0);
>+    aWindow.setTimeout(function(){
[Since you're changing it, it would be nice to have a space before the { ]

>+      let ident = aDocIdentMap[aEntry.docIdentifier];
>+      if (!ident) {
[This will generate a JS strict warning if there is no entry in the map yet. The easiest workaround is not to use the temporary ident variable.]
Attachment #438352 - Flags: superreview?(neil)
Attachment #438352 - Flags: superreview+
Attachment #438352 - Flags: review?(neil)
Attachment #438352 - Flags: review+
(Assignee)

Comment 2

7 years ago
Created attachment 438416 [details] [diff] [review]
for checkin

Neil nits fixed.
Attachment #438352 - Attachment is obsolete: true
Attachment #438416 - Flags: superreview+
Attachment #438416 - Flags: review+
(Assignee)

Comment 3

7 years ago
Forgot mention, carrying forward r+ sr+ from Neil
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
(Assignee)

Comment 4

7 years ago
checking ping
(Assignee)

Comment 5

7 years ago
Pushed http://hg.mozilla.org/comm-central/rev/b9dd99c8bf28
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Target Milestone: --- → seamonkey2.1a1
(Assignee)

Updated

6 years ago
Blocks: 640165
No longer blocks: 640165
You need to log in before you can comment on or make changes to this bug.