558657 - [mozilla-1.9.2 branch] static build with tests enabled fails in toolkit/crashreporter/test

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Hideo Oshima]

Attachment: Build log

Cannot build thunderbird trunk from comm-central.

I use Debian GNU/Linux unstable amd64.
gcc 4:4.4.3-1
python 2.6.5-1

Please tell me if more information is needed.

Comment 1

[Ludovic Hirlimann [:Usul]]

can you share your .mozconfig ?
and #maildev is more suited for those kind of requests.

Comment 2

[Hideo Oshima]

(In reply to comment #1)
> can you share your .mozconfig ?

Here is my .mozconfig

ac_add_options --enable-application=mail
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/tb-opt
mk_add_options AUTOCONF=autoconf2.13
mk_add_options MOZ_MAKE_FLAGS="-j4"
ac_add_options --enable-static

> and #maildev is more suited for those kind of requests.

Thanks for your information.

Comment 3

[Ludovic Hirlimann [:Usul]]

And the log doesn't really show where you are breaking ...

Comment 4

[Mark Banner (:standard8)]

The error looks like it is in crash reporter, therefore moving to core, as that is part of core.

Comment 5

[Hideo Oshima]

(In reply to comment #4)
> The error looks like it is in crash reporter, therefore moving to core, as that
> is part of core.

I add 'ac_add_options --disable-crashreporter' in to .mozconfig
then build fineshed successfully.
I think you are right.

Comment 6

[Jim Blandy :jimb]

It looks to me like the problem is that SHARED_LIBRARY is the empty string in this command from toolkit/crashreporter/test/Makefile.in:

	$(INSTALL) $(SHARED_LIBRARY) \
          $(DEPTH)/_tests/xpcshell/$(MODULE)/unit/components

That same makefile is working fine in M-C builds; here's the corresponding 'make' output on a Linux M-C build this morning:

/home/jimb/mc/in/obj-bug/config/nsinstall -R libtestcrasher.so \
          ../../../_tests/xpcshell/crashreporter_test/unit/components

I don't have any insight as to why SHARED_LIBRARY would be set in M-C but not in Thunderbird.

Comment 7

[(not currently active) Ted Mielczarek]

(In reply to comment #2)
> (In reply to comment #1)
> > can you share your .mozconfig ?
> 
> Here is my .mozconfig
...
> ac_add_options --enable-static

I suspect this is why it's broken. That component probably doesn't get built in a static build (it probably can't be linked, at least not currently), but the libs:: rule at the bottom of that Makefile doesn't check for that:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/test/Makefile.in#89

We could wrap that last $(INSTALL) command in "ifndef BUILD_STATIC_LIBS".

Comment 8

[Mark Banner (:standard8)]

FWIW: the reason we don't see this on tinderboxes or in the release builds, is that by default we always have --enable-static and --disable-tests together, tests are enabled by default which is why just --enable-static builds will see this.

Comment 9

[Mark Banner (:standard8)]

Attachment: The fix

Fix as suggested by Ted. I've tested it and it works fine on the 1.9.2 branch.

I don't think this is required on trunk, because trunk now additionally copies the xpt files and therefore it has something to copy into that directory (and it isn't using SHARED_LIBRARY there.

So therefore I'm proposing this patch as a fix for some TB source builders on 1.9.2 branch only.

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 461197 [details] [diff] [review]
The fix

Requesting approval for 1.9.2 branch on this bustage fix for some build configurations of Thunderbird.

Comment 11

[Daniel Veditz [:dveditz]]

Comment on attachment 461197 [details] [diff] [review]
The fix

Approved for 1.9.2.11, a=dveditz for release-drivers

Comment 12

[Mark Banner (:standard8)]

Checked into 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/e2e9073312a3

Comment 13

[Al Billings [:abillings - ex-MoCo]]

Verified through source inspection for 1.9.2 Whee.