Closed Bug 558678 Opened 15 years ago Closed 14 years ago

intermittent test reftest/tests/modules/libpr0n/test/reftest/gif/delaytest.html?transparent-animation.gif

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 629632

People

(Reporter: joe, Assigned: ehsan.akhgari)

References

Details

(Keywords: intermittent-failure)

The reftest in question waits 500ms for a 30ms animation to complete, but this is obviously inherently flaky since, if the image takes a long time to load off disk, the animation won't be animated by then. I'm going to create a fix that should paper over this a little (wait for onload before waiting for the animation), but we need a real fix. I think this real fix should be something like an onframe - a callback that fires on every frame. It doesn't need to send much information, because we can do all the counting and other accounting ourselves, but we need to add it to enable testing.
Crap. I can't actually fix this how I wanted - with onload - because delaytest.html already uses onload. :(
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1273634061.1273634624.13531.gz WINNT 5.2 mozilla-central opt test reftest on 2010/05/11 20:14:21 s: mw32-ix-slave04
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1274666071.1274668114.351.gz Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test reftest on 2010/05/23 18:54:31 s: talos-r3-snow-029
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1274739630.1274742357.26587.gz Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test reftest on 2010/05/24 15:20:30 s: talos-r3-snow-034
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1274757253.1274759617.596.gz Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test reftest on 2010/05/24 20:14:13 s: talos-r3-snow-027
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1274776710.1274779785.21848.gz Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test reftest on 2010/05/25 01:38:30 s: talos-r3-snow-024
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1274840790.1274843272.13674.gz Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test reftest on 2010/05/25 19:26:30
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1274904692.1274907457.2099.gz Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test reftest on 2010/05/26 13:11:32 s: talos-r3-snow-029
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1274925332.1274927847.25267.gz Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test reftest on 2010/05/26 18:55:32 s: talos-r3-snow-012
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1275022502.1275024704.17511.gz Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test reftest on 2010/05/27 21:55:02
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1275046122.1275048515.4000.gz Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test reftest [testfailed] Started 04:28, finished 05:09, took 41mins Fri May 28 04:07:27 2010 s: talos-r3-snow-019
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1275058402.1275060869.9824.gz Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test reftest on 2010/05/28 07:53:22
this is getting pretty bad. Joe, do you think we should disable the test until we get this figured out?
Test disabled. http://hg.mozilla.org/mozilla-central/rev/94f92b34e535 Adding a new "onframe" event is probably the sanest fix, but it might have performance implications. Can you use existing paint events, or use a mochitest that polls until it gets the rendering it wants?
Whiteboard: [orange] → [orange][test disabled]
Odd that after working fine for _2 years_ this decides to start failing... Anyway. I wonder if it would be useful to add a way for reftests to poll. eg, if a comparison fails, retry the test (not reference) after 500ms, and retry until it passes (giving up after some max interval). Might be a generic solution useful elsewhere?
I think we should just poll in the test here. E.g., every 10ms we could draw the image to a canvas, call getImageData on the canvas looking for a particular color at a certain pixel, and when we see the right color, then we remove reftest-wait.
I'm fixing this as part of my patch in bug 629632.
Assignee: nobody → ehsan
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
Whiteboard: [orange][test disabled] → [orange]
No longer blocks: 438871
Whiteboard: [orange]
Serge, please stop removing the orange annotations from valid intermittent orange bugs.
Blocks: 438871
Whiteboard: [orange]
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.