Update Modern theme for videocontrols including HTML5 CSS Transitions

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: neil, Assigned: philip.chee)

Tracking

({modern})

Trunk
modern
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
For some reason the CSS rules added to toolkit (p/winstripe) videocontrols.css were all jammed together without any blank lines.
(Assignee)

Comment 1

8 years ago
Morphing this bug slightly to cover the following:

Bug 489902 - video controls should prefer a specific font name
Bug 520614 - Fix usage of vbox in videocontrols.xml
Bug 521890 - Use CSS Transitions for HTML5 videocontrols
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Depends on: 520614, 489902
Keywords: helpwanted
Summary: Update Modern theme for HTML5 videocontrols CSS Transitions → Update Modern theme for videocontrols including HTML5 CSS Transitions
(Assignee)

Comment 2

8 years ago
Created attachment 448973 [details] [diff] [review]
Patch v1.0 sync with toolkit

>-  font: 11px sans-serif;
>+  font-size: 11px;
>+  font-family: Helvetica, Arial, sans-serif;

winstripe uses Arial, san-serif;
pinstripe uses Helvetica, san-serif;

OS X ships with both Helvetica and Arial so Helvetica should be selected first.

Windows 7 ships with Arial but not Helvetica out of the box so Arial should be selected first. If the user chooses to install Helvetica then we assume he likes it enough to use it. In either case, they should be better choices than the generic san-serif.
Attachment #448973 - Flags: feedback?(neil)
(Reporter)

Comment 3

8 years ago
(In reply to comment #1)
> Bug 489902 - video controls should prefer a specific font name
This landed on 1.9.1.x; should it land on 2.0.x?
(Reporter)

Comment 4

8 years ago
Comment on attachment 448973 [details] [diff] [review]
Patch v1.0 sync with toolkit

>+}
>+.statusOverlay[fadeout] {
Nit: Blank line in between.
Attachment #448973 - Flags: review+
Attachment #448973 - Flags: feedback?(neil)
Attachment #448973 - Flags: feedback+
(Assignee)

Comment 5

8 years ago
>>+}
>>+.statusOverlay[fadeout] {
> Nit: Blank line in between.
Fixed locally.

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/59716a0a03cc
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.