558828 - Article edit email notifications don't say what content has changed

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Chris Ilias [:cilias]]

Reported at <https://support.mozilla.com/en-US/forum/3/647673>, and I can confirm in the emails that I have received. 

When I get an email telling me "Wiki page *staging-copy changed by username", the message contains the article source, and a link to the diff, but does not inclide the diff in the message.

It goes from "If you don't want to receive these notifications follow this link:
https://support.mozilla.com/tiki-user_watches.php?hash=foo"
to
***********************************************************
The new page content follows below.
***********************************************************

Comment 1

[Chris Ilias [:cilias]]

-->WONTFIX
I shouldn't have bothered to file this bug, because it's not critical and resources should go to Kitsune.
http://blog.mozilla.com/sumo/2010/03/31/sumo-platform-roadmap-for-the-rest-of-2010-milestonesand-priorities/
Sorry for wasting everyone's time.

Comment 2

[Kadir Topal [:atopal]]

Contributors made it clear, that they need this to save time and effort, we should take it into 1.5.4, if it's not a huge amount of work.

Comment 3

[David Tenser [:djst]]

Kadir, not sure if you already talked to James/Paul, but to everyone else, the original reason for why this was disabled in the first place was to improve performance. It is my understanding that disabling it didn't have a significant impact on the performance, so that's why we're suggesting that we re-enable it since this is a serious l10n workflow regression.

Comment 4

[Bogdancev]

Please include this feature back as it really helps me.

Comment 5

[Paul Craciunoiu [:paulc]]

Attachment: revert notification template

Looks to me like this is the only thing that remained to be reverted. Testing locally shows me a notification with a diff in it.

FTR, I compared these two revisions:
http://viewvc.svn.mozilla.org/vc?view=revision&revision=64841
http://viewvc.svn.mozilla.org/vc?view=revision&revision=65201

Comment 6

[James Socol [:jsocol, :james]]

Comment on attachment 440256 [details] [diff] [review]
revert notification template

Looks good to me. Compared with
    svn diff -r 64840:64842 webroot/templates/styles/mozkb/mail/user_watch_wiki_page_changed.tpl

Comment 7

[Paul Craciunoiu [:paulc]]

r66208.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of the diff of changes

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of email notification

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.