Closed
Bug 558978
Opened 15 years ago
Closed 15 years ago
Looks like composition isn't committed after I clicked
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: inputmethod, regression)
Attachments
(1 file, 1 obsolete file)
|
2.12 KB,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
This is regression of bug 520732.
If I use SCIM, the ResetInputState() should still work. However, after bug 520732, the composition is committed by click but the committed string is still selected by IME selection after it's really committed.
The cause is nsGtkIMModule::OnEndCompositionNative() dispatches composition end event even when ShouldIgnoreNativeCompositionEvent() returns true. By it, editor ends composition with composing string. And CommitCompositionBy("") which is called by ResetInputState() will be ignored by editor because its composition was already finished by the intentional composition event.
And the patch fixes a bug of logging. The code logs composition string which was freed.
Attachment #438662 -
Flags: review?(karlt)
|
Assignee | |
Comment 1•15 years ago
|
||
oops, sorry for the spam.
Attachment #438662 -
Attachment is obsolete: true
Attachment #438663 -
Flags: review?(karlt)
Attachment #438662 -
Flags: review?(karlt)
|
||
Updated•15 years ago
|
Attachment #438663 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
|
|
Assignee | |
Updated•15 years ago
|
Keywords: inputmethod
You need to log in
before you can comment on or make changes to this bug.
Description
•