Closed Bug 558981 Opened 10 years ago Closed 10 years ago

Rev3 Fedora permaorange: reftests/text-decoration/underline-block-propagation-2-standards.html

Categories

(Core :: Layout: Block and Inline, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: philor, Assigned: zwol)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

RelEng is switching from running reftests on the old CentOS refplatform to the
Talos Rev3 Fedora 12 refplatform. One of the failures blocking the switch is
that reftests/text-decoration/underline-block-propagation-2-standards.html consistently fails,
e.g., 

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1271131169.1271131977.7552.gz#err14
Rev3 Fedora 12 mozilla-central opt test reftest on 2010/04/12 20:59:29
s: talos-r3-fed-037

REFTEST TEST-UNEXPECTED-FAIL | file:///home/cltbld/talos-slave/mozilla-central-fedora-opt-u-reftest/build/reftest/tests/layout/reftests/text-decoration/underline-block-propagation-2-standards.html |
No longer blocks: 558910
Hi Zack,
We are looking into fixing perma-oranges that we now have on Fedora unit tests.

One of them is this test that you originally wrote.
If I got you access to a Fedora 12 machine do you think you could help me fix it? or you have access to a Fedora machine?
Attached file reftest log snippet
Looks like the native textarea has rounded corners and is actually transparent outside those corners, and it therefore doesn't cover up the underline underneath it.  That doesn't happen on my machine, but I can see the underline underneath if I give the textarea opacity.

Seems like we could probably fix this by adjusting the reference.
Attached patch candidate patchSplinter Review
Something like this maybe?  I am not entirely happy with the span with the  s inside in the reference, but I couldn't find a better way.
Assignee: nobody → zweinberg
Status: NEW → ASSIGNED
Attachment #442218 - Flags: review?(dbaron)
Comment on attachment 442218 [details] [diff] [review]
candidate patch

sure, r=dbaron
Attachment #442218 - Flags: review?(dbaron) → review+
http://hg.mozilla.org/mozilla-central/rev/c8e77c61cfed

There have been two cycles on the F12 reftest column since then that show underline-block-propagation-2-standards.html as passing, whereas the build right before that shows it failing:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1272558397.1272560971.1650.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1272562314.1272564608.12055.gz 

vs

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1272556704.1272559417.29563.gz
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
One more down! Yoohoo!

Thanks Zack :)
Just for note keeping, same failure was also caught on windows 7:

REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest/build/reftest/tests/layout/reftests/text-decoration/underline-block-propagation-2-standards.html |
REFTEST number of differing pixels: 4
Alice, was that before or after the landing in comment 5?
Before.

I was just adding it here to cross some t's and dot some i's.
Blocks: 438871
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.