Closed
Bug 559067
Opened 15 years ago
Closed 15 years ago
tracemonkey MSVC warnings fixes
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: MikeM, Unassigned)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
6.26 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
There are more warnings on Tracemonkey tip.
\js\src\jsscan.h(346) : warning C4800: 'uintN' : forcing value to bool 'true' or 'false' (performance warning)
\js\src\jsscan.h(347) : warning C4800: 'uintN' : forcing value to bool 'true' or 'false' (performance warning)
\js\src\jsscan.h(348) : warning C4800: 'uintN' : forcing value to bool 'true' or 'false' (performance warning)
\js\src\jsscan.h(349) : warning C4800: 'uintN' : forcing value to bool 'true' or 'false' (performance warning)
\js\src\jsscan.h(350) : warning C4800: 'const uintN' : forcing value to bool 'true' or 'false' (performance warning)
\js\src\jscntxt.h(1666) : warning C4512: 'js::AutoGCRooter' : assignment operator could not be generated
\js\src\jscntxt.h(1614) : see declaration of 'js::AutoGCRooter'
\js\src\jscntxt.h(1683) : warning C4512: 'js::AutoSaveWeakRoots' : assignment operator could not be generated
\js\src\jscntxt.h(1668) : see declaration of 'js::AutoSaveWeakRoots'
\js\src\jscntxt.h(1740) : warning C4512: 'js::AutoValueRooter' : assignment operator could not be generated
\js\src\jscntxt.h(1686) : see declaration of 'js::AutoValueRooter'
\js\src\jscntxt.h(1768) : warning C4512: 'js::AutoObjectRooter' : assignment operator could not be generated
\js\src\jscntxt.h(1742) : see declaration of 'js::AutoObjectRooter'
\js\src\jscntxt.h(1796) : warning C4512: 'js::AutoArrayRooter' : assignment operator could not be generated
\js\src\jscntxt.h(1770) : see declaration of 'js::AutoArrayRooter'
\js\src\jscntxt.h(1812) : warning C4512: 'js::AutoScopePropertyRooter' : assignment operator could not be generated
\js\src\jscntxt.h(1798) : see declaration of 'js::AutoScopePropertyRooter'
\js\src\jscntxt.h(1832) : warning C4512: 'js::AutoScriptRooter' : assignment operator could not be generated
\js\src\jscntxt.h(1814) : see declaration of 'js::AutoScriptRooter'
\js\src\jscntxt.h(1857) : warning C4512: 'js::AutoIdRooter' : assignment operator could not be generated
\js\src\jscntxt.h(1834) : see declaration of 'js::AutoIdRooter'
\js\src\jscntxt.h(1934) : warning C4512: 'js::AutoEnumStateRooter' : assignment operator could not be generated
\js\src\jscntxt.h(1897) : see declaration of 'js::AutoEnumStateRooter'
\js\src\jscntxt.h(1949) : warning C4512: 'js::AutoXMLRooter' : assignment operator could not be generated
\js\src\jscntxt.h(1937) : see declaration of 'js::AutoXMLRooter'
\js\src\jstl.h(184) : warning C4100: 'obj' : unreferenced formal parameter
\js\src\jsvector.h(446) : see reference to function template instantiation 'js::ReentrancyGuard::ReentrancyGuard<js::Vector<T,N>>(js::Vector<T,N> &)' being compiled
with
[
T=jsval,
N=8
]
\js\src\jsvector.h(445) : while compiling class template member function 'js::Vector<T,N>::~Vector(void)'
with
[
T=jsval,
N=8
]
\js\src\jscntxt.h(2459) : see reference to class template instantiation 'js::Vector<T,N>' being compiled
with
[
T=jsval,
N=8
]
Reporter | ||
Updated•15 years ago
|
Attachment #438771 -
Attachment is patch: true
Attachment #438771 -
Attachment mime type: application/octet-stream → text/plain
Reporter | ||
Updated•15 years ago
|
Attachment #438771 -
Flags: review?(jorendorff)
Comment 1•15 years ago
|
||
Comment on attachment 438771 [details] [diff] [review]
patch for tip
I think
!!(foo & BIT)
is closer to our style than
(foo & BIT) == BIT
Apart from style issues, this looks fine. I'll land it tomorrow.
Attachment #438771 -
Flags: review?(jorendorff) → review+
Reporter | ||
Comment 2•15 years ago
|
||
picked style nits.
Attachment #438771 -
Attachment is obsolete: true
Attachment #439366 -
Flags: review?(jorendorff)
Updated•15 years ago
|
Attachment #439366 -
Flags: review?(jorendorff) → review+
Comment 3•15 years ago
|
||
Whiteboard: fixed-in-tracemonkey
Comment 4•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•