559132 - Nanojit needs an embedding API

Status: RESOLVED WONTFIX

(Core Graveyard :: Nanojit, enhancement)

Description

[Edwin Smith]

This is a tracking bug to discuss and clean up nanojit's configuration and dependency on avmplus.h

general problem statements:

* including avmplus.h is weird; nanojit should include *something* that allows the embedding VM to provide definitions for external references.  

* nanojit depends on VMPI_xxx functions which come from tamarin's platform porting layer.  having such a layer is good, and we could keep that convention.  or we could change it within nanojit.  (in scope but not as important as the avmplus.h issues).

* embedding nanojit requires the host to define certian ifdefs, but they aren't well documented or named, and they probably should be.

* in some places, nanojit still refers to AvmCore, AvmLog, etc.  at the very least, those names should be changed

A goal is to keep the runtime abstraction cost as low as possible; it is currently zero in many cases.

TODO

* attach a list of all api's (classes, ifdefs, functions) nanojit depends on the host VM to provide

Comment 1

[Nicholas Nethercote [inactive]]

A small thing that came up in bug 558723 -- NJ defines the stdint types on Windows.  TM also does this, and TM has a hack whereby it defines the preprocessor constant _STDINT_H in order to suppress NJ's versions.  This means that TM's jsstdint.h file must be #include before any NJ header, which is a bit annoying.

Comment 2

[Jim Blandy :jimb]

For what it's worth, VS2010 is alleged to have <stdint.h>.

Comment 3

[Nicholas Nethercote [inactive]]

Bug 617244 removes AvmCore.

Comment 4

[Nicholas Nethercote [inactive]]

Bug 624604 is open to reduce the amount of exported stuff.

Comment 5

[Nicholas Nethercote [inactive]]

Nanojit is long gone from Mozilla code.