559174 - Change signature for hangs

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Benjamin Smedberg]

The current signature we get from hangs is not ideal. There are a couple changes we should make:

1) if a HangID is present in the incoming data, prefix the signature with "hang|"

So a crash which would now have a signature of "KiFastSystemCallRet" would have a signature of "hang|KiFastSystemCallRet"

2) If "CrashReporter::CreatePairedMinidumps" is present in the report, look for "mozilla::ipc::RPCChannel::Call". Create the signature from one frame above. So, for this report:

https://crash-stats.mozilla.com/report/index/bp-52386e46-faab-40fb-a188-1d27d2100411

The signature should be "hang|mozilla::plugins::PPluginInstanceParent::CallNPP_Destroy(short*)"

This should be implementable entirely separately from bug 544940.

Comment 1

[K Lars Lohn [:lars] [:klohn]]

In 1.6.2:
  * the overall signature of a crash will be prefixed with "hang | " 
    if HangID is present in the json
  * changed how signatureSentinels work:
  ** added conditional sentinel in the config.  They consist of a tuple of 
     a string and a function. The string is the sentinel to be applied iff 
     the function returns true when passed the whole list of frame signatures
  * changed processorconfig.py.dist  to use the new class of signatureSentinel
  ** 'mozilla::ipc::RPCChannel::Call(IPC::Message*, IPC::Message*)' is a 
     signature sentinel iff 'CrashReporter::CreatePairedMinidumps(void*, 
     unsigned long, nsAString_internal*, nsILocalFile**, nsILocalFile**)'
     is found somewhere in the stack frame.
  ** 'mozilla::ipc::RPCChannel::Call(IPC::Message*, IPC::Message*)' is added 
     to the irrelevantSignatureRegEx to eliminate it as the top of the stack
     after the signature sentinel trims the stack frame

Comment 2

[Benjamin Smedberg]

This isn't working correctly. RPCChannel::Call is the signature for most parent hangs, now, instead of its caller, e.g.

http://crash-stats.mozilla.com/report/index/cc0229d2-423a-4cc6-a5de-49f5c2100503

The signature should be

hang | mozilla::plugins::PPluginScriptableObjectParent::CallGetChildProperty(mozilla::plugins::PPluginIdentifierParent*,bool*,bool*,mozilla::plugins::Variant*,bool*)

Comment 3

[K Lars Lohn [:lars] [:klohn]]

IT request 563364 verifies that IT missed a configuration change in the push to 1.6.2.  They have corrected their oversight.  New crashes should reflect the proper signature from this point on.

I will leave this bug reopened until I see for myself that it is working properly.

Comment 4

[Benjamin Smedberg]

http://crash-stats.mozilla.com/report/index/a33e95bd-dc7e-4f9a-a6cf-b9bd32100503