Closed Bug 559182 Opened 14 years ago Closed 14 years ago

10.6 unit tests are not currently running

Categories

(Release Engineering :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: armenzg, Assigned: armenzg)

References

Details

Attachments

(4 files, 3 obsolete files)

1) The step is run without failing: make: Nothing to be done for `buildsymbols'. 2) Nothing gets uploaded 3) The sendchange for it is send 4) The unit test fails because it can't find the file > --14:09:09-- http://stage.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-macosx64-debug/1271190183/firefox-3.7a5pre.en-US.mac64.crashreporter-symbols.zip > => `firefox-3.7a5pre.en-US.mac64.crashreporter-symbols.zip' > Resolving stage.mozilla.org... 10.2.74.116 > Connecting to stage.mozilla.org|10.2.74.116|:80... connected. > HTTP request sent, awaiting response... 404 Not Found > 14:09:10 ERROR 404: Not Found Until this bug is not fixed we won't have unit tests for 10.6
I think you want download_symbols to be set to false in the Talos configs, actually?
disable download_symbols for macosx64 on staging and production
Attachment #438862 - Flags: feedback?(bhearsum)
Attachment #438862 - Attachment is obsolete: true
Attachment #438871 - Flags: review?(armenzg)
Attachment #438862 - Flags: feedback?(bhearsum)
Comment on attachment 438871 [details] [diff] [review] disable download_symbols for macosx64 talos tests >diff --git a/mozilla2-staging/config.py b/mozilla2-staging/config.py >--- a/mozilla2-staging/config.py >+++ b/mozilla2-staging/config.py >@@ -196,37 +196,34 @@ PLATFORM_VARS = { > }, > 'macosx64': { > 'base_name': 'OS X 10.6 %(branch)s', > 'mozconfig': 'macosx64/%(branch)s/nightly', > 'profiled_build': False, > 'builds_before_reboot': 5, > 'build_space': 8, > 'upload_symbols': True, >- 'download_symbols': True, >+ 'download_symbols': False, We need upload symbols to be False as well. >- 'talos_masters': [ >- ('talos-staging-master02.build.mozilla.org:9010', False), >- ('talos-staging-master02.build.mozilla.org:9012', False), >- ], >+ 'talos_masters': GLOBAL_VARS['talos_masters'], > }, Let's not take a change like this on bustage patch (yes, this one it is :D) > 'build_space': 8, > 'upload_symbols': True, >- 'download_symbols': True, >+ 'download_symbols': False, > The same as previous comment.
Attachment #438871 - Flags: review?(armenzg) → review-
set upload_symbols to False also and removed talos-master change for now - moving to a non-bustage patch
Attachment #438871 - Attachment is obsolete: true
Attachment #438873 - Flags: review?(armenzg)
Comment on attachment 438873 [details] [diff] [review] disable download_symbols for macosx64 talos tests I will land this when pm becomes available. Bear this bug is now all in my hands. Thanks for your help.
Attachment #438873 - Flags: review?(armenzg) → review+
Attachment #438873 - Flags: checked-in+
I still have to see if we actually need this patch.
Summary: 10.6 builds should have uploadSymbols set to False → 10.6 unit tests are not currently running
Summary update: * The fix commited this morning was not sufficient and was trying to fix the wrong problem (The problem is not that we don't produce symbols for 10.6) * The actual problem is that packages are not being generated since opt_unittests are disabled for this platform * The patches posted help this situation but I had not had enough time to see if the sendchanges are being picked up on the talos-staging-master and if triggered the unit tests over there * I will continue this in the morning
Bear I am taking this if you don't mind :)
Assignee: bear → armenzg
Status: NEW → ASSIGNED
Attachment #439085 - Flags: review?(bear)
Attachment #439085 - Flags: review?(bear) → review+
Attachment #439088 - Attachment is obsolete: true
Attachment #439247 - Flags: review?(lsblakk) → review+
Comment on attachment 439247 [details] [diff] [review] 10.6 doesn't yet have symbols and we should not try to download them http://hg.mozilla.org/build/buildbot-configs/rev/72feb055bf31
Attachment #439247 - Flags: checked-in+
Comment on attachment 439085 [details] [diff] [review] packageTests for 10.6 so we can run unit tests on talos http://hg.mozilla.org/build/buildbot-configs/rev/3bd75e03bba4
Attachment #439085 - Flags: checked-in+
OK all looking good. I will wait to see builds triggered by devs and then see it run the unit tests on talos before I close this.
These are being triggered. I will file other bugs for the perma-oranges.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: