Closed
Bug 559182
Opened 14 years ago
Closed 14 years ago
10.6 unit tests are not currently running
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: armenzg, Assigned: armenzg)
References
Details
Attachments
(4 files, 3 obsolete files)
1.96 KB,
patch
|
armenzg
:
review+
armenzg
:
checked-in+
|
Details | Diff | Splinter Review |
1.58 KB,
patch
|
bear
:
review+
armenzg
:
checked-in+
|
Details | Diff | Splinter Review |
1.82 KB,
patch
|
lsblakk
:
review+
armenzg
:
checked-in+
|
Details | Diff | Splinter Review |
1.55 KB,
patch
|
coop
:
review+
|
Details | Diff | Splinter Review |
1) The step is run without failing:
make: Nothing to be done for `buildsymbols'.
2) Nothing gets uploaded
3) The sendchange for it is send
4) The unit test fails because it can't find the file
> --14:09:09-- http://stage.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-macosx64-debug/1271190183/firefox-3.7a5pre.en-US.mac64.crashreporter-symbols.zip
> => `firefox-3.7a5pre.en-US.mac64.crashreporter-symbols.zip'
> Resolving stage.mozilla.org... 10.2.74.116
> Connecting to stage.mozilla.org|10.2.74.116|:80... connected.
> HTTP request sent, awaiting response... 404 Not Found
> 14:09:10 ERROR 404: Not Found
Until this bug is not fixed we won't have unit tests for 10.6
Comment 1•14 years ago
|
||
I think you want download_symbols to be set to false in the Talos configs, actually?
Comment 2•14 years ago
|
||
disable download_symbols for macosx64 on staging and production
Attachment #438862 -
Flags: feedback?(bhearsum)
Comment 3•14 years ago
|
||
Attachment #438862 -
Attachment is obsolete: true
Attachment #438871 -
Flags: review?(armenzg)
Attachment #438862 -
Flags: feedback?(bhearsum)
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 438871 [details] [diff] [review]
disable download_symbols for macosx64 talos tests
>diff --git a/mozilla2-staging/config.py b/mozilla2-staging/config.py
>--- a/mozilla2-staging/config.py
>+++ b/mozilla2-staging/config.py
>@@ -196,37 +196,34 @@ PLATFORM_VARS = {
> },
> 'macosx64': {
> 'base_name': 'OS X 10.6 %(branch)s',
> 'mozconfig': 'macosx64/%(branch)s/nightly',
> 'profiled_build': False,
> 'builds_before_reboot': 5,
> 'build_space': 8,
> 'upload_symbols': True,
>- 'download_symbols': True,
>+ 'download_symbols': False,
We need upload symbols to be False as well.
>- 'talos_masters': [
>- ('talos-staging-master02.build.mozilla.org:9010', False),
>- ('talos-staging-master02.build.mozilla.org:9012', False),
>- ],
>+ 'talos_masters': GLOBAL_VARS['talos_masters'],
> },
Let's not take a change like this on bustage patch (yes, this one it is :D)
> 'build_space': 8,
> 'upload_symbols': True,
>- 'download_symbols': True,
>+ 'download_symbols': False,
>
The same as previous comment.
Attachment #438871 -
Flags: review?(armenzg) → review-
Comment 5•14 years ago
|
||
set upload_symbols to False also and removed talos-master change for now - moving to a non-bustage patch
Attachment #438871 -
Attachment is obsolete: true
Attachment #438873 -
Flags: review?(armenzg)
Assignee | ||
Comment 6•14 years ago
|
||
Comment on attachment 438873 [details] [diff] [review]
disable download_symbols for macosx64 talos tests
I will land this when pm becomes available.
Bear this bug is now all in my hands.
Thanks for your help.
Attachment #438873 -
Flags: review?(armenzg) → review+
Assignee | ||
Comment 7•14 years ago
|
||
Comment on attachment 438873 [details] [diff] [review]
disable download_symbols for macosx64 talos tests
http://hg.mozilla.org/build/buildbot-configs/rev/46dfd16e7371
Attachment #438873 -
Flags: checked-in+
Assignee | ||
Comment 8•14 years ago
|
||
Assignee | ||
Comment 9•14 years ago
|
||
I still have to see if we actually need this patch.
Assignee | ||
Updated•14 years ago
|
Summary: 10.6 builds should have uploadSymbols set to False → 10.6 unit tests are not currently running
Assignee | ||
Comment 10•14 years ago
|
||
Summary update:
* The fix commited this morning was not sufficient and was trying to fix the wrong problem (The problem is not that we don't produce symbols for 10.6)
* The actual problem is that packages are not being generated since opt_unittests are disabled for this platform
* The patches posted help this situation but I had not had enough time to see if the sendchanges are being picked up on the talos-staging-master and if triggered the unit tests over there
* I will continue this in the morning
Assignee | ||
Comment 11•14 years ago
|
||
Bear I am taking this if you don't mind :)
Assignee: bear → armenzg
Status: NEW → ASSIGNED
Assignee | ||
Updated•14 years ago
|
Blocks: darwin_unittests
Assignee | ||
Updated•14 years ago
|
Attachment #439085 -
Flags: review?(bear)
Updated•14 years ago
|
Attachment #439085 -
Flags: review?(bear) → review+
Assignee | ||
Comment 12•14 years ago
|
||
Attachment #439247 -
Flags: review?(lsblakk)
Assignee | ||
Updated•14 years ago
|
Attachment #439088 -
Attachment is obsolete: true
Updated•14 years ago
|
Attachment #439247 -
Flags: review?(lsblakk) → review+
Assignee | ||
Comment 13•14 years ago
|
||
Comment on attachment 439247 [details] [diff] [review]
10.6 doesn't yet have symbols and we should not try to download them
http://hg.mozilla.org/build/buildbot-configs/rev/72feb055bf31
Attachment #439247 -
Flags: checked-in+
Assignee | ||
Comment 14•14 years ago
|
||
Comment on attachment 439085 [details] [diff] [review]
packageTests for 10.6 so we can run unit tests on talos
http://hg.mozilla.org/build/buildbot-configs/rev/3bd75e03bba4
Attachment #439085 -
Flags: checked-in+
Assignee | ||
Comment 15•14 years ago
|
||
Updated•14 years ago
|
Attachment #439314 -
Flags: review+
Assignee | ||
Comment 16•14 years ago
|
||
OK all looking good. I will wait to see builds triggered by devs and then see it run the unit tests on talos before I close this.
Assignee | ||
Comment 17•14 years ago
|
||
These are being triggered.
I will file other bugs for the perma-oranges.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•