Closed Bug 559259 Opened 14 years ago Closed 14 years ago

Core Animation in process should use IOSurface

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(2 files, 2 obsolete files)

In Process IOSurface
6.43 KB, patch
jaas
: review+
Details | Diff | Splinter Review
Bustage fix: Export symboles
677 bytes, patch
Details | Diff | Splinter Review 
We can use IOSurface on OSX 10.6 from the out of process patch to bypass glReadPixels and improve performance.
Depends on: 555281
Attached patch In Process IOSurface (obsolete) — — Splinter Review 

        Attachment #442405 -
        Flags: review?(joshmoz)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        In Process IOSurface (obsolete)
        — 
          — Splinter Review
      

    


  
Fixed a leak with the previous patch.
Assignee: nobody → b56girard

        Attachment #442405 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #442405 -
        Flags: review?(joshmoz)

    
  

        Attachment #442413 -
        Flags: review?(joshmoz)

    
    

    
  


  
Applied Review comments.

        Attachment #442413 -
        Attachment is obsolete: true

        Attachment #442568 -
        Flags: review?(joshmoz)

        Attachment #442413 -
        Flags: review?(joshmoz)

    
  
Blocks: 556282

    
  

        Attachment #442568 -
        Flags: review?(joshmoz) → review+

    
    

    
  
Is there an issue with Thunderbird and this patch?
http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1274388711.1274389049.2561.gz

    
    

    
  


  
I forgot to add THEBES_API to export the symbols.

    
    

    
  
Pushed to mozilla-central:
Patch: c57f18783b12 
Bustage fix: fef4737a3feb

According to the log that was all the missing symbols so this fix should do the trick.

    
    

    
  
Verified for in/out-of-process Core Animation with:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a5pre) Gecko/20100521 Minefield/3.7a5pre
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: