559261 - Midas Demo not preserving line breaks and indentation in HTML Source view

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Biju]

Attachment: MidasDemo.html

In "View HTML Source" mode if you enter new lines and spaces,
it wont be preserved when next time you come to source view.
new lines are gone an spaces for indentation will be replaced with  

Steps:-
1. go to http://www.mozilla.org/editor/midasdemo/index.html
2. click to check "View HTML Source"
3. Enter following HTML 

<ol>
  <li>level 1</li>
  <ol>
    <li>level 1.1</li>
    <ol>
      <li>level 1.1.1</li>
      <li>level 1.1.2</li>
    </ol>
    <li>level 1.2</li>
  </ol>
  <li>level 2</li>
  <li>level 3</li>
</ol>


4. click to uncheck "View HTML Source"
5. click again to check "View HTML Source"

result:-
you lost all formatting, ie new lines and indentations 


This can be fixed by code change in function "viewsource(source)"
See attached MidasDemo.html

Comment 1

[Boris Zbarsky [:bzbarsky]]

Is this a regression?  If so, from when?

Comment 2

[Mounir Lamouri (:mounir)]

Probably a duplicate from bug 596455

Comment 3

[Mounir Lamouri (:mounir)]

Actually, loosing new lines might be related to bug 596455 but I do not see how indentation could be related...

Comment 4

[Biju]

(In reply to comment #2)
> Probably a duplicate from bug 596455

From you test case at bug 596455, this is not dupe

Here the problem is

  var divnode = document.createElement('div');
  var htmlrange = document.body.ownerDocument.createRange();
  divnode.innerHTML = "aaaa<br>bbbb<br>cccc";
  htmlrange.selectNodeContents(divnode);
  alert(htmlrange.toString()); 

gives "aaaabbbbcccc"

Per bz (bug 596455 Comment 13) it is right behaviour.
And issue with indentation is because of non-preformatted text collapse space while displaying.  

(In reply to comment #1)
> Is this a regression?  If so, from when?

I see same issue at google doc in Edit HTML View, since its introduction till the feature removed. 

test in 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) 
Gecko/20081106 SeaMonkey/2.0a2pre
I see same problem

So I dont think it is a regression just that nobody have tested that way I think.

Comment 5

[(no longer active)]

I think this is INVALID then, right?

Comment 6

[Mounir Lamouri (:mounir)]

I would prefer to mark it fixed by bug 596455.
Biju, it could be nice if you can confirm that is fixed with the latest nightly.

Comment 7

[Biju]

retested on 
Mozilla/5.0 (Windows NT 6.0; rv:2.0b7pre) 
Gecko/20100921 Firefox/4.0b7pre

bug 559261 FAIL
bug 596455 PASS

(In reply to comment #5)
> I think this is INVALID then, right?

NO....

This bug is against  
   Product:  Websites
   Component: www.mozilla.org

I have already submitted FIX for this issue, ie attachment 438938 [details]
I dont know how/(not have resource) to make patch

Can you assign to somebody who have time to do so...

Comment 8

[Mounir Lamouri (:mounir)]

Oh, it wasn't clear. This bug has nothing to do with bug 596455 and that's not a regression.

Pascal, do you know who should be pinged for this bug (it's a mozilla.org page)?

Comment 9

[David Boswell]

The pages in the Editor section are owned by Ehsan now, I believe.

Comment 10

[(no longer active)]

Attachment: Patch

Comment 11

[(no longer active)]

Fixed in r74817.

David, do you know how can I update the code on mozilla.org with this revision?

Comment 12

[David Boswell]

Changes to trunk go straight to the live site after 10 minutes or so, so you should be all set with that commit.

Comment 13

[(no longer active)]

Indeed they're already live on mozilla.org.

Thanks a lot, Biju, for the patch!

Comment 14

[Biju]

Thanks... Its working...