Closed
Bug 559338
Opened 15 years ago
Closed 15 years ago
auto_dirac leaks info when dirac_parse_info fails
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
VERIFIED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, memory-leak)
Attachments
(1 file)
|
758 bytes,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
366 auto_dirac (OGGZ * oggz, long serialno, unsigned char * data, long length, void * user_data)
371 info = oggz_malloc(sizeof(dirac_info));
374 if (dirac_parse_info(info, data, length) == -1)
375 return -1;
|
||
Comment 2•15 years ago
|
||
We don't use liboggz on trunk any more (bug 556455 will delete it shortly), but it might be worth fixing this on the branches.
|
||
Comment 3•15 years ago
|
||
thanks, applied in upstream liboggz commit 5ed43da65aef47fbde54e27e79bcd681dbf89193
|
||
Comment 4•15 years ago
|
||
We've removed liboggz on trunk, please reopen if you care about fixing this on branch.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #438991 -
Flags: review?(kinetik) → review+
as this is only a potential leak, i'm quite happy with it just being fixed upstream, thanks. (i've marked r+ since someone took it upstream which means someone must have liked it)
Status: RESOLVED → VERIFIED
|
||
Updated•7 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•