Closed Bug 559349 Opened 10 years ago Closed 10 years ago

nsNPAPIPluginInstance::ScheduleTimer leaks newTimer when do_CreateInstance fails

Categories

(Core :: Plug-ins, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file)

1737 nsNPAPIPluginInstance::ScheduleTimer(uint32_t interval, NPBool repeat, void (*timerFunc)(NPP npp, uint32_t timerID))
1739   nsNPAPITimer *newTimer = new nsNPAPITimer();
1751   nsCOMPtr<nsITimer> xpcomTimer = do_CreateInstance(NS_TIMER_CONTRACTID, &rv);
1752   if (NS_FAILED(rv))
1753     return 0;
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #439001 - Flags: review?(jst)
Attachment #439001 - Flags: review?(jst) → review+
http://hg.mozilla.org/mozilla-central/rev/5c6cc0a94d41
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.