559431 - Change tab context menu "Open in New Window" to "Detach Tab"

Status: RESOLVED DUPLICATE of bug 593646

(Firefox :: Menus, defect)

Description

[Jennifer Morrow [:Boriss] (UX)]

The phrase "Open in New Window" is less descriptive of what detaching a tab does.  Because we use this same phrase for opening a link in a new window, we're unnecessarily confusing two similar concepts to the user; creating a new instance of a location and moving a location out of the tab bar.  If we called opening a tab in a window "detach tab" instead, it would not only be a better description of what is actually happening, but would let users know that detaching tabs is possible.  Currently, opening in a new window relates to creating a new instance and thus users may see "open in new window" and assume a new instance is being created.

Comment 1

[Gubment Cheez]

I don't agree with this. Open in a new window does exactly what it says, opens the tab in a new window. to me, detaching a tab would be the same as opening the tab in a reduced window, (like a popup), and would be give me an unexpected result

Comment 2

[Tyler Downer [He/Him]]

Attachment: Patch WIP

Something like this then?

Comment 3

[Michael Kohler [:mkohler]]

Comment on attachment 439099 [details] [diff] [review]
Patch WIP

>diff --git a/browser/locales/en-US/chrome/browser/browser.dtd b/browser/locales/en-US/chrome/browser/browser.dtd
>--- a/browser/locales/en-US/chrome/browser/browser.dtd
>+++ b/browser/locales/en-US/chrome/browser/browser.dtd
> ....
>-<!ENTITY  openTabInNewWindow.label           "Open in a New Window">
>-<!ENTITY  openTabInNewWindow.accesskey       "W">
>+<!ENTITY  detachTab.label           		 "Detach Tab">
>+<!ENTITY  detachTab.accesskey       		 "D">

Please align it with "W". Otherwise this should be okay AFAIK. Let's ask for review.But maybe we need ui-r+ for this.

Comment 4

[Tyler Downer [He/Him]]

Attachment: Patch v1

This should do it then.

Comment 5

[eyal gruss]

see also Bug 593646 - suggesting the change to "move to new window"