559435 - Include the email of the person who comments and the short summary inside tbpl automatic bug comments

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[(no longer active)]

Shaver wants our Robot to put the short summary of the failure, and the email of the person starring the orange (or whatever they enter in that textbox) inside the bug comment, and I think it's a useful addition, so I'll write a patch for it.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 439107 [details] [diff] [review]
Patch (v1)

>+    NetUtils.loadText("submitBugzillaComment.php?id=" + id + "&comment=" + escape(email + "\n" + logLink + "\n" + header + "\n\n" + summary),

Really, the whole summary? Let's see how this goes.

>+      var log = [];
>+      for (var child = summaryPlaceholder.firstChild;
>+           child; child = child.nextSibling) {
>+        if (child.nodeType == child.TEXT_NODE) {
>+          var str = child.textContent.trim();
>+          if (str != "") {
>+            log.push(str);
>+          }
>+        }
>+      }
>+      log = log.join("\n");

Let's make this:
      var log = $(summaryPlaceholder)
        .contents(function () { return this.nodeType == this.TEXT_NODE; })
        .map(function () { return this.textContent.trim() || null; })
        .get().join("\n");

Comment 3

[(no longer active)]

(In reply to comment #2)
> Let's make this:
>       var log = $(summaryPlaceholder)
>         .contents(function () { return this.nodeType == this.TEXT_NODE; })
>         .map(function () { return this.textContent.trim() || null; })
>         .get().join("\n");

Neat trick!  Except that contents doesn't take an argument, so I applied filter() to the result of contents before passing it to map.

Comment 4

[(no longer active)]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/fdcb0c2fade9

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(Just now saw one of these new-style tbplrobot comments…)

Since Bugzilla has for some time sanitized (hidden) email addresses from non-logged-in users, there's been a much better chance of not getting spam based on bots harvesting Bugzilla.

However, this change now inserts raw emails into comments, defeating that protection (unless a user manually enters an "obfuscated" email address on tbpl).  Is it worth doing a simple translation/obfuscation to restore this protection?

Comment 6

[Mike Shaver (:shaver emeritus)]

That same text appears on tinderbox unobfuscated, if that informs our decision here.  (The tbox entry isn't forever the way a bug comment is, to be sure.)

Comment 7

[(no longer active)]

I pushed a small tweak to replace "@" with "%" in the email addresses before they go inside comments.  Hopefully this will at least force spammers to tweak their scraping tools!

Markus, could you please deploy that patch?

Comment 8

[(no longer active)]

Someone decided that this is now a confidential bug.  I don't think so!

Comment 9

[Markus Stange [:mstange]]

(In reply to comment #7)
> Markus, could you please deploy that patch?

Done.