If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix ctypes closures to work on a non-GC thread

RESOLVED FIXED

Status

()

Core
js-ctypes
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Ben Turner (not reading bugmail, use the needinfo flag!), Assigned: Ben Turner (not reading bugmail, use the needinfo flag!))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 439098 [details] [diff] [review]
Patch, v1

ctypes currently assumes that GC happens on the same thread that closures run on. This isn't always true!
Attachment #439098 - Flags: review?(dwitte)

Comment 1

8 years ago
Comment on attachment 439098 [details] [diff] [review]
Patch, v1

Looks good, but I'd make the 'cxThread' member and its setter expression '#ifdef DEBUG', since that's the only place you're using it.

r=dwitte
Attachment #439098 - Flags: review?(dwitte) → review+
Blocks: 559447
Created attachment 439130 [details] [diff] [review]
Patch, updated to comments
Attachment #439098 - Attachment is obsolete: true
Attachment #439130 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/8fcc3d64b8c6
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.