Closed Bug 559492 Opened 12 years ago Closed 12 years ago

Only dump leaked URLs on successful shutdown

Categories

(Core :: Networking, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: karlt, Assigned: karlt)

Details

Attachments

(1 file, 1 obsolete file)

Dumping leaked URLs on abnormal early exit can make the cause of the error
harder to see (e.g. bug 559454) or lost entirely if it disappears out of the
scrollback buffer.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → karlt
Status: NEW → ASSIGNED
Attachment #439159 - Flags: review?(dbaron)
I support the goal of this patch.
Comment on attachment 439159 [details] [diff] [review]
patch

r=dbaron
Attachment #439159 - Flags: review?(dbaron) → review+
Attached patch patch v2Splinter Review
Added a check for gInitialized in ShutdownGlobalObjects as
necko (nsNetModule.cpp) calls ShutdownGlobalObjects but not
InitGlobalObjects.
Attachment #439159 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/ea52363cc860
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.