All users were logged out of Bugzilla on October 13th, 2018

Only dump leaked URLs on successful shutdown

RESOLVED FIXED in mozilla1.9.3a5

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: karlt, Assigned: karlt)

Tracking

Trunk
mozilla1.9.3a5
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Dumping leaked URLs on abnormal early exit can make the cause of the error
harder to see (e.g. bug 559454) or lost entirely if it disappears out of the
scrollback buffer.
(Assignee)

Comment 1

9 years ago
Created attachment 439159 [details] [diff] [review]
patch
Assignee: nobody → karlt
Status: NEW → ASSIGNED
Attachment #439159 - Flags: review?(dbaron)
I support the goal of this patch.
Comment on attachment 439159 [details] [diff] [review]
patch

r=dbaron
Attachment #439159 - Flags: review?(dbaron) → review+
(Assignee)

Comment 4

9 years ago
Created attachment 442305 [details] [diff] [review]
patch v2

Added a check for gInitialized in ShutdownGlobalObjects as
necko (nsNetModule.cpp) calls ShutdownGlobalObjects but not
InitGlobalObjects.
Attachment #439159 - Attachment is obsolete: true
(Assignee)

Comment 5

9 years ago
http://hg.mozilla.org/mozilla-central/rev/ea52363cc860
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.