Don't appear preview message on new biff window when receiving multiple messages

RESOLVED FIXED in Thunderbird 3.1b2

Status

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
Thunderbird 3.1b2
All
Windows Vista
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

9 years ago
I found this when I as implementing bug 555536.

- Step
receive several messages

- Result
Although new biff notification window appears on right bottom, message preview is first message only.  (2nd, 3rd and etc is subject and sender only)

- Expected
preview message should appears on all new message.


This is invalid usage of nsISeekableStream.  We should not use NS_SEEK_CUR since this is the offset in message box.

http://mxr.mozilla.org/comm-central/source/mailnews/local/src/nsLocalMailFolder.cpp#3963
(Assignee)

Comment 1

9 years ago
Also, this is on Windows only.  Mac doesn't use preview text and I am implementing it by bug 555536.
(Assignee)

Comment 2

9 years ago
Created attachment 439210 [details] [diff] [review]
patch
(Assignee)

Updated

9 years ago
Attachment #439210 - Flags: review?(bienvenu)

Comment 3

9 years ago
Comment on attachment 439210 [details] [diff] [review]
patch

it would be nice if the test at the end checked that the preview text was accurate, not just empty. But thx very much for the patch and the test.
Attachment #439210 - Flags: review?(bienvenu) → review+
(Assignee)

Comment 4

9 years ago
Created attachment 439428 [details] [diff] [review]
patch v1 with updated test
(Assignee)

Comment 5

9 years ago
Created attachment 439430 [details] [diff] [review]
patch v1 with updated test
Attachment #439428 - Attachment is obsolete: true
(Assignee)

Comment 6

9 years ago
Comment on attachment 439430 [details] [diff] [review]
patch v1 with updated test

update unit test by bienvenu's comment
Attachment #439430 - Flags: superreview?(bugzilla)
Attachment #439430 - Flags: superreview?(bugzilla) → superreview+
(Assignee)

Comment 7

9 years ago
http://hg.mozilla.org/comm-central/rev/eae0e1ee6c34
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b2
You need to log in before you can comment on or make changes to this bug.