559528 - Don't appear preview message on new biff window when receiving multiple messages

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Makoto Kato [:m_kato]]

I found this when I as implementing bug 555536.

- Step
receive several messages

- Result
Although new biff notification window appears on right bottom, message preview is first message only.  (2nd, 3rd and etc is subject and sender only)

- Expected
preview message should appears on all new message.


This is invalid usage of nsISeekableStream.  We should not use NS_SEEK_CUR since this is the offset in message box.

http://mxr.mozilla.org/comm-central/source/mailnews/local/src/nsLocalMailFolder.cpp#3963

Comment 1

[Makoto Kato [:m_kato]]

Also, this is on Windows only.  Mac doesn't use preview text and I am implementing it by bug 555536.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: patch

Comment 3

[David :Bienvenu]

Comment on attachment 439210 [details] [diff] [review]
patch

it would be nice if the test at the end checked that the preview text was accurate, not just empty. But thx very much for the patch and the test.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: patch v1 with updated test

Comment 5

[Makoto Kato [:m_kato]]

Attachment: patch v1 with updated test

Comment 6

[Makoto Kato [:m_kato]]

Comment on attachment 439430 [details] [diff] [review]
patch v1 with updated test

update unit test by bienvenu's comment

Comment 7

[Makoto Kato [:m_kato]]

http://hg.mozilla.org/comm-central/rev/eae0e1ee6c34