Closed Bug 559528 Opened 11 years ago Closed 11 years ago

Don't appear preview message on new biff window when receiving multiple messages

Categories

(MailNews Core :: Database, defect)

All
Windows Vista
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1b2

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(2 files, 1 obsolete file)

I found this when I as implementing bug 555536.

- Step
receive several messages

- Result
Although new biff notification window appears on right bottom, message preview is first message only.  (2nd, 3rd and etc is subject and sender only)

- Expected
preview message should appears on all new message.


This is invalid usage of nsISeekableStream.  We should not use NS_SEEK_CUR since this is the offset in message box.

http://mxr.mozilla.org/comm-central/source/mailnews/local/src/nsLocalMailFolder.cpp#3963
Also, this is on Windows only.  Mac doesn't use preview text and I am implementing it by bug 555536.
Attached patch patchSplinter Review
Attachment #439210 - Flags: review?(bienvenu)
Comment on attachment 439210 [details] [diff] [review]
patch

it would be nice if the test at the end checked that the preview text was accurate, not just empty. But thx very much for the patch and the test.
Attachment #439210 - Flags: review?(bienvenu) → review+
Attached patch patch v1 with updated test (obsolete) — Splinter Review
Attachment #439428 - Attachment is obsolete: true
Comment on attachment 439430 [details] [diff] [review]
patch v1 with updated test

update unit test by bienvenu's comment
Attachment #439430 - Flags: superreview?(bugzilla)
Attachment #439430 - Flags: superreview?(bugzilla) → superreview+
http://hg.mozilla.org/comm-central/rev/eae0e1ee6c34
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b2
You need to log in before you can comment on or make changes to this bug.