559537 - Under VS2010, fatal error occurs at atlcore.h

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[Edmund Wong (:ewong)]

Building under VS2010, a fatal error C1189 occurs  at atlcore.h(35) with
the error message:

D:\vs2010\VC\ATLMFC\INCLUDE\atlcore.h(35) : fatal error C1189: #error :
 This file requires _WIN32_WINNT to be #defined at least to 0x0403.  Value
 0x0501 or higher is recommended.

As shown in http://mxr.mozilla.org/mozilla-central/source/embedding/browser/activex/src/plugin/StdAfx.h#52, 

_WIN32_WINNT is defined as 0x0400.

Workaround:  add compile option --disable-activex

Comment 1

[(not currently active) Ted Mielczarek]

I hit this while fixing bug 530093 but didn't get around to fixing it, since there was an easy workaround. I'm not sure what the right fix is here. We could just bump the #define up, but I don't know if that will break things.

Comment 2

[(not currently active) Ted Mielczarek]

Edmund: would you like to try the obvious fix, and just change that #define to
#define _WIN32_WINNT 0x0403
?

Comment 3

[Edmund Wong (:ewong)]

I'll get a patch up asap.

Comment 4

[Edmund Wong (:ewong)]

Attachment: Changed _WIN32_WINNT from 0x0400 to 0x0403

Comment 5

[Edmund Wong (:ewong)]

Comment on attachment 443261 [details] [diff] [review]
Changed _WIN32_WINNT  from 0x0400 to 0x0403

It seems as if _WIN32_WINNT definition is sprinkled over quite a few files that need updating.  I'm obsoleting this patch until I get a better patch done.

Comment 6

[Edmund Wong (:ewong)]

Attachment: Changed all instances _WIN32_WINNT 0x0400 to _WIN32_WINNT 0x0403

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 443285 [details] [diff] [review]
Changed all instances _WIN32_WINNT 0x0400 to _WIN32_WINNT 0x0403

Seems like the simplest thing we can do.

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/89d91f98ca9d