Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Under VS2010, fatal error occurs at atlcore.h

RESOLVED FIXED in mozilla1.9.3a5

Status

Core Graveyard
Embedding: ActiveX Wrapper
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: ewong, Assigned: ewong)

Tracking

Trunk
mozilla1.9.3a5
x86
Windows Vista

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Building under VS2010, a fatal error C1189 occurs  at atlcore.h(35) with
the error message:

D:\vs2010\VC\ATLMFC\INCLUDE\atlcore.h(35) : fatal error C1189: #error :
 This file requires _WIN32_WINNT to be #defined at least to 0x0403.  Value
 0x0501 or higher is recommended.

As shown in http://mxr.mozilla.org/mozilla-central/source/embedding/browser/activex/src/plugin/StdAfx.h#52, 

_WIN32_WINNT is defined as 0x0400.

Workaround:  add compile option --disable-activex
I hit this while fixing bug 530093 but didn't get around to fixing it, since there was an easy workaround. I'm not sure what the right fix is here. We could just bump the #define up, but I don't know if that will break things.
Edmund: would you like to try the obvious fix, and just change that #define to
#define _WIN32_WINNT 0x0403
?
Blocks: 563318
(Assignee)

Comment 3

7 years ago
I'll get a patch up asap.
(Assignee)

Updated

7 years ago
Assignee: nobody → ewong
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 4

7 years ago
Created attachment 443261 [details] [diff] [review]
Changed _WIN32_WINNT  from 0x0400 to 0x0403
(Assignee)

Updated

7 years ago
Attachment #443261 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 5

7 years ago
Comment on attachment 443261 [details] [diff] [review]
Changed _WIN32_WINNT  from 0x0400 to 0x0403

It seems as if _WIN32_WINNT definition is sprinkled over quite a few files that need updating.  I'm obsoleting this patch until I get a better patch done.
Attachment #443261 - Attachment is obsolete: true
Attachment #443261 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 6

7 years ago
Created attachment 443285 [details] [diff] [review]
Changed all instances _WIN32_WINNT 0x0400 to _WIN32_WINNT 0x0403
Attachment #443285 - Flags: review?(ted.mielczarek)
Comment on attachment 443285 [details] [diff] [review]
Changed all instances _WIN32_WINNT 0x0400 to _WIN32_WINNT 0x0403

Seems like the simplest thing we can do.
Attachment #443285 - Flags: review?(ted.mielczarek) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/89d91f98ca9d
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Component: Embedding: ActiveX Wrapper → Embedding: ActiveX Wrapper
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.