Closed Bug 559537 Opened 11 years ago Closed 11 years ago

Under VS2010, fatal error occurs at atlcore.h

Categories

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: ewong, Assigned: ewong)

References

Details

Attachments

(1 file, 1 obsolete file)

Building under VS2010, a fatal error C1189 occurs  at atlcore.h(35) with
the error message:

D:\vs2010\VC\ATLMFC\INCLUDE\atlcore.h(35) : fatal error C1189: #error :
 This file requires _WIN32_WINNT to be #defined at least to 0x0403.  Value
 0x0501 or higher is recommended.

As shown in http://mxr.mozilla.org/mozilla-central/source/embedding/browser/activex/src/plugin/StdAfx.h#52, 

_WIN32_WINNT is defined as 0x0400.

Workaround:  add compile option --disable-activex
I hit this while fixing bug 530093 but didn't get around to fixing it, since there was an easy workaround. I'm not sure what the right fix is here. We could just bump the #define up, but I don't know if that will break things.
Edmund: would you like to try the obvious fix, and just change that #define to
#define _WIN32_WINNT 0x0403
?
I'll get a patch up asap.
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #443261 - Flags: review?(ted.mielczarek)
Comment on attachment 443261 [details] [diff] [review]
Changed _WIN32_WINNT  from 0x0400 to 0x0403

It seems as if _WIN32_WINNT definition is sprinkled over quite a few files that need updating.  I'm obsoleting this patch until I get a better patch done.
Attachment #443261 - Attachment is obsolete: true
Attachment #443261 - Flags: review?(ted.mielczarek)
Comment on attachment 443285 [details] [diff] [review]
Changed all instances _WIN32_WINNT 0x0400 to _WIN32_WINNT 0x0403

Seems like the simplest thing we can do.
Attachment #443285 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/89d91f98ca9d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.