559651 - Remove EventInfo wrapper

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch to remove all EventInfo reference

There is no need for an EventInfo wrapper. The only additional property it adds was the time of the generated event.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Updated on trunk and really remove only the EventInfo code (and where it is used)

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 458329 [details] [diff] [review]
Patch v0.2

>diff -r 36723271befb chrome/content/InputHandler.js
>+    aEvent.time = Date.now();

Do we even use "time" anywhere?

MXR says we don't

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #2)
> Comment on attachment 458329 [details] [diff] [review]
> Patch v0.2
> 
> >diff -r 36723271befb chrome/content/InputHandler.js
> >+    aEvent.time = Date.now();
> 
> Do we even use "time" anywhere?
> 
> MXR says we don't

yep we do:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/InputHandler.js#644

http://hg.mozilla.org/mobile-browser/rev/d39aff00f0f5