Closed
Bug 559651
Opened 15 years ago
Closed 15 years ago
Remove EventInfo wrapper
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vingtetun, Assigned: vingtetun)
Details
Attachments
(1 file, 1 obsolete file)
14.88 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
There is no need for an EventInfo wrapper. The only additional property it adds was the time of the generated event.
Attachment #439342 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 1•15 years ago
|
||
Updated on trunk and really remove only the EventInfo code (and where it is used)
Assignee: nobody → 21
Attachment #439342 -
Attachment is obsolete: true
Attachment #458329 -
Flags: review?(mark.finkle)
Attachment #439342 -
Flags: review?(mark.finkle)
Comment 2•15 years ago
|
||
Comment on attachment 458329 [details] [diff] [review]
Patch v0.2
>diff -r 36723271befb chrome/content/InputHandler.js
>+ aEvent.time = Date.now();
Do we even use "time" anywhere?
MXR says we don't
Attachment #458329 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 3•15 years ago
|
||
(In reply to comment #2)
> Comment on attachment 458329 [details] [diff] [review]
> Patch v0.2
>
> >diff -r 36723271befb chrome/content/InputHandler.js
> >+ aEvent.time = Date.now();
>
> Do we even use "time" anywhere?
>
> MXR says we don't
yep we do:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/InputHandler.js#644
http://hg.mozilla.org/mobile-browser/rev/d39aff00f0f5
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•