559738 - [k] Redirect /en-us to /en-US

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[James Socol [:jsocol, :james]]

See bug 559086 comment 1.

Changed my mind because I know how to fix it.

Comment 1

[James Socol [:jsocol, :james]]

Pull request sent for r?

http://github.com/jsocol/kitsune/commit/f1d55ab27582f34be0b79912224b8413bca6a01c

Comment 2

[James Socol [:jsocol, :james]]

http://github.com/jsocol/kitsune/commit/e047ae4eff1230e09de849f983a9dfbd05e34a5a

Build #22.

Comment 3

[David Tenser [:djst]]

Not to be bikeshedding here but from where are we getting incoming "en-us" requests? And wouldn't this also potentially apply for other locales, too, making a general xx-yy -> xx-YY fix more appropriate?

Comment 4

[James Socol [:jsocol, :james]]

(In reply to comment #3)
> Not to be bikeshedding here but from where are we getting incoming "en-us"
> requests? And wouldn't this also potentially apply for other locales, too,
> making a general xx-yy -> xx-YY fix more appropriate?

1) Someone could type it. Then they would have a hard time searching. (Especially if they typed pt-br, for example, that doesn't have the same xx-YY -> xx conversion that English has internally.) Previously redirects from /xx were going to /xx-yy, as well. That's been fixed in another bug.

2) The fix works for any locale. Feel free to change the summary if you want.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Looks good for http://support-stage-new.mozilla.com/en-us/search



GET /en-us/search HTTP/1.1

Host: support-stage-new.mozilla.com

<snip>

HTTP/1.1 301 MOVED PERMANENTLY

Date: Sun, 18 Apr 2010 01:52:14 GMT

Server: Apache/2.2.3 (Red Hat)

Location: http://support-stage-new.mozilla.com/en-US/search

Cache-Control: max-age=0

Expires: Sun, 18 Apr 2010 01:52:14 GMT

Content-Length: 0

Keep-Alive: timeout=5, max=1000

Connection: Keep-Alive

Content-Type: text/html; charset=utf-8

----------------------------------------------------------


http://support-stage-new.mozilla.com/en-US/search


But, neither for http://support-stage-new.mozilla.com/en-us/ nor http://support-stage-new.mozilla.com/en-us, which do *not* 301 MOVED PERMANENTLY to http://support-stage-new.mozilla.com/en-US/.

Comment 6

[James Socol [:jsocol, :james]]

Those URLs are not handled by Kitsune and thus outside the scope of a [k] bug. They'll eventually get fixed as we move the rest of the site over.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED per comment 5, now that I understand, per comment 6.  Thanks, James.